From 0ac0f355e50639fb2cdacb6cbfca696d5592a89e Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Sun, 23 Feb 2025 21:00:57 -0800 Subject: [PATCH] ; Tag all erc-nicks-track-faces tests as :unstable * test/lisp/erc/erc-nicks-tests.el (erc-nicks-track-faces/prioritize): Tag as :unstable, regardless of environment, pending further investigation. This has reportedly failed on Emacs 31 and Emacs 28. (erc-nicks-track-faces/defer, erc-nicks-track-faces/nil): Tag as :unstable even though there haven't been any reported failures as yet. (erc-nicks-track-faces/t): Likewise. This test has failed on Emacs 31 on a GitLab.com runner. (Bug#76188) --- test/lisp/erc/erc-nicks-tests.el | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/lisp/erc/erc-nicks-tests.el b/test/lisp/erc/erc-nicks-tests.el index 805c41e7023..92960d79d6f 100644 --- a/test/lisp/erc/erc-nicks-tests.el +++ b/test/lisp/erc/erc-nicks-tests.el @@ -615,7 +615,7 @@ (erc-tests-common-kill-buffers)) (ert-deftest erc-nicks-track-faces/prioritize () - :tags (and (null (getenv "CI")) '(:unstable)) + :tags '(:unstable) (should (eq erc-nicks-track-faces 'prioritize)) (erc-nicks-tests--track-faces @@ -683,6 +683,7 @@ (funcall assert-result '(7 . erc-notice-face))))) (ert-deftest erc-nicks-track-faces/defer () + :tags '(:unstable) (when (< emacs-major-version 28) (ert-skip "Possible intermittent failures on 27")) @@ -751,6 +752,8 @@ (funcall assert-result '(7 . erc-notice-face)))))) (ert-deftest erc-nicks-track-faces/nil () + :tags '(:unstable) + (should (eq erc-nicks-track-faces 'prioritize)) (let (erc-nicks-track-faces) (erc-nicks-tests--track-faces @@ -795,6 +798,8 @@ (funcall assert-result '(5 . erc-notice-face)))))) (ert-deftest erc-nicks-track-faces/t () + :tags '(:unstable) + (should (eq erc-nicks-track-faces 'prioritize)) (let ((erc-nicks-track-faces t)) (erc-nicks-tests--track-faces