From 2f9067da367fdb8ace512e52b18c02e443ba3894 Mon Sep 17 00:00:00 2001 From: Gareth Rees Date: Sun, 6 Apr 2014 15:52:56 +0100 Subject: [PATCH] Event arenablacklistzone was deleted, but event_version_minor was not updated; and the instruction "when you retire an event type, don't delete it from the list -- comment it out" was not followed. Delete TODO item: EVENT_VERSION numbers are parameters to the EventInit event. Copied from Perforce Change: 185246 ServerID: perforce.ravenbrook.com --- mps/code/eventdef.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mps/code/eventdef.h b/mps/code/eventdef.h index cc3b3d61c21..4ce313dcfc8 100644 --- a/mps/code/eventdef.h +++ b/mps/code/eventdef.h @@ -1,7 +1,7 @@ /* -- Event Logging Definitions * * $Id$ - * Copyright (c) 2001-2013 Ravenbrook Limited. See end of file for license. + * Copyright (c) 2001-2014 Ravenbrook Limited. See end of file for license. * * .source: * @@ -31,14 +31,13 @@ * the median version when changing an existing event, * and the major version when changing the format of the event file. * - * TODO: These should go into a header that appears at the start of a - * telemetry stream, but they aren't currently used. Keep updating them - * anyway. RB 2012-09-07 + * These are passed as parameters to the EventInit event at the start + * of a telemetry stream, allowing that stream to be identified. */ #define EVENT_VERSION_MAJOR ((unsigned)1) #define EVENT_VERSION_MEDIAN ((unsigned)1) -#define EVENT_VERSION_MINOR ((unsigned)6) +#define EVENT_VERSION_MINOR ((unsigned)7) /* EVENT_LIST -- list of event types and general properties @@ -192,7 +191,8 @@ /* new events for performance analysis of large heaps. */ \ EVENT(X, TraceCondemnZones , 0x0083, TRUE, Trace) \ EVENT(X, ArenaGenZoneAdd , 0x0084, TRUE, Arena) \ - EVENT(X, ArenaUseFreeZone , 0x0085, TRUE, Arena) + EVENT(X, ArenaUseFreeZone , 0x0085, TRUE, Arena) \ + /* EVENT(X, ArenaBlacklistZone , 0x0086, TRUE, Arena) */ /* Remember to update EventNameMAX and EventCodeMAX above! @@ -745,7 +745,7 @@ /* C. COPYRIGHT AND LICENSE * - * Copyright (C) 2001-2013 Ravenbrook Limited . + * Copyright (C) 2001-2014 Ravenbrook Limited . * All rights reserved. This is an open source license. Contact * Ravenbrook for commercial licensing options. *