Github/emacs
2
0
Fork 1
mirror of git://git.sv.gnu.org/emacs.git synced 2026-02-17 18:37:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

* lisp/term/ns-win.el (parameters): Don't declare as dynamic.

Browse source 
(before-make-frame-hook): Don't add ineffective function.
This commit is contained in:
Stefan Monnier 2013-09-12 16:21:41 -04:00
parent ae5e4c483a
commit 379add74c2
2 changed files with 5 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lisp/ChangeLog
View file

@ -1,5 +1,8 @@
2013-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
* term/ns-win.el (parameters): Don't declare as dynamic.
(before-make-frame-hook): Don't add ineffective function.
* eshell/*.el: Use lexical-binding (bug#15231).
2013-09-12 Kenichi Handa <handa@gnu.org>

24
lisp/term/ns-win.el
View file

@ -556,29 +556,9 @@ unless the current buffer is a scratch buffer."
(interactive)
(other-frame -1))
;; If no position specified, make new frame offset by 25 from current.
;; You'd think this was a window manager's job, but apparently without
;; this, new frames open exactly on top of old ones (?).
;; http://lists.gnu.org/archive/html/emacs-devel/2010-10/msg00988.html
;; Note that AFAICS it is not documented that functions on
;; before-make-frame-hook can access PARAMETERS.
(defvar parameters) ; dynamically bound in make-frame
(add-hook 'before-make-frame-hook
(lambda ()
(let ((left (cdr (assq 'left (frame-parameters))))
(top (cdr (assq 'top (frame-parameters)))))
(if (consp left) (setq left (cadr left)))
(if (consp top) (setq top (cadr top)))
(cond
((or (assq 'top parameters) (assq 'left parameters)))
((or (not left) (not top)))
(t
(setq parameters (cons (cons 'left (+ left 25))
(cons (cons 'top (+ top 25))
parameters))))))))
;; frame will be focused anyway, so select it
;; Frame will be focused anyway, so select it
;; (if this is not done, mode line is dimmed until first interaction)
;; FIXME: Sounds like we're working around a bug in the underlying code.
(add-hook 'after-make-frame-functions 'select-frame)
(defvar tool-bar-mode)