* lisp/emacs-lisp/bytecomp.el (byte-compile-dynamic): Mark obsolete

See bug#11649 for an example problem, and emacs-devel discussion
«Prickliness of the "invalid byte code" stuff».

* lisp/wid-edit.el, lisp/wdired.el, lisp/vc/pcvs-util.el:
* lisp/progmodes/executable.el, lisp/mail/sendmail.el:
* lisp/emacs-lisp/cl-seq.el, lisp/emacs-lisp/cl-macs.el:
* lisp/emacs-lisp/cl-lib.el, lisp/emacs-lisp/cl-extra.el:
* lisp/dired-x.el, lisp/dired-aux.el, lisp/calendar/calendar.el:
Don't use byte-compile-dynamic any more.
This commit is contained in:
Stefan Monnier 2019-06-21 10:30:50 -04:00
parent 869cf5cbc0
commit 436ccc6967
14 changed files with 12 additions and 29 deletions

View file

@ -472,6 +472,12 @@ current and the previous or the next line, as before.
* Changes in Specialized Modes and Packages in Emacs 27.1
** byte compiler
*** byte-compile-dynamic is now obsolete
This is because on the one hand it suffers from various misbehaviors in corner
cases that have plagued it for years, and on the other experiments indicated
that it doesn't bring any measurable benefit.
** compile.el
---
*** In 'compilation-error-regexp-alist', 'line' (and 'end-line') can

View file

@ -212,8 +212,7 @@ update the calendar display to reflect the change, otherwise
movement commands will not work correctly."
:type 'integer
;; Change the initialize so that if you reload calendar.el, it will not
;; cause a redraw (which may fail, e.g. with "invalid byte-code in
;; calendar.elc" because of the "byte-compile-dynamic").
;; cause a redraw.
:initialize 'custom-initialize-default
:set (lambda (sym val)
(set sym val)
@ -2666,8 +2665,4 @@ If called by a mouse-event, pops up a menu with the result."
(provide 'calendar)
;; Local variables:
;; byte-compile-dynamic: t
;; End:
;;; calendar.el ends here

View file

@ -2959,7 +2959,6 @@ instead."
(provide 'dired-aux)
;; Local Variables:
;; byte-compile-dynamic: t
;; generated-autoload-file: "dired-loaddefs.el"
;; End:

View file

@ -1598,7 +1598,6 @@ If `current-prefix-arg' is non-nil, uses name at point as guess."
(provide 'dired-x)
;; Local Variables:
;; byte-compile-dynamic: t
;; generated-autoload-file: "dired-loaddefs.el"
;; End:

View file

@ -240,6 +240,7 @@ For example, add -*-byte-compile-dynamic: t;-*- on the first line.
When this option is true, if you load the compiled file and then move it,
the functions you loaded will not be able to run.")
(make-obsolete-variable 'byte-compile-dynamic "not worthwhile any more." "27.1")
;;;###autoload(put 'byte-compile-dynamic 'safe-local-variable 'booleanp)
(defvar byte-compile-disable-print-circle nil
@ -1031,7 +1032,7 @@ If STR is something like \"Buffer foo.el\", return #<buffer foo.el>
str))
(defconst emacs-lisp-compilation-parse-errors-filename-function
'emacs-lisp-compilation-file-name-or-buffer
#'emacs-lisp-compilation-file-name-or-buffer
"The value for `compilation-parse-errors-filename-function' for when
we go into emacs-lisp-compilation-mode.")

View file

@ -938,7 +938,6 @@ Outputs to the current buffer."
(run-hooks 'cl-extra-load-hook)
;; Local variables:
;; byte-compile-dynamic: t
;; generated-autoload-file: "cl-loaddefs.el"
;; End:

View file

@ -660,8 +660,4 @@ of record objects."
(t
(advice-remove 'type-of #'cl--old-struct-type-of))))
;; Local variables:
;; byte-compile-dynamic: t
;; End:
;;; cl-lib.el ends here

View file

@ -3397,7 +3397,6 @@ STRUCT and SLOT-NAME are symbols. INST is a structure instance."
(run-hooks 'cl-macs-load-hook)
;; Local variables:
;; byte-compile-dynamic: t
;; generated-autoload-file: "cl-loaddefs.el"
;; End:

View file

@ -1038,7 +1038,6 @@ Atoms are compared by `eql'; cons cells are compared recursively.
(run-hooks 'cl-seq-load-hook)
;; Local variables:
;; byte-compile-dynamic: t
;; generated-autoload-file: "cl-loaddefs.el"
;; End:

View file

@ -2078,9 +2078,4 @@ you can move to one of them and type C-c C-c to recover that one."
;; Do not add anything but external entries on this page.
(provide 'sendmail)
;; Local Variables:
;; byte-compile-dynamic: t
;; End:
;;; sendmail.el ends here

View file

@ -1,4 +1,4 @@
;;; executable.el --- base functionality for executable interpreter scripts -*- byte-compile-dynamic: t -*-
;;; executable.el --- base functionality for executable interpreter scripts
;; Copyright (C) 1994-1996, 2000-2019 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; pcvs-util.el --- utility functions for PCL-CVS -*- byte-compile-dynamic: t -*-
;;; pcvs-util.el --- utility functions for PCL-CVS
;; Copyright (C) 1991-2019 Free Software Foundation, Inc.

View file

@ -913,9 +913,4 @@ Like original function but it skips read-only words."
(cons changes errors)))
(provide 'wdired)
;; Local Variables:
;; byte-compile-dynamic: t
;; End:
;;; wdired.el ends here

View file

@ -1,4 +1,4 @@
;;; wid-edit.el --- Functions for creating and using widgets -*-byte-compile-dynamic: t; lexical-binding:t -*-
;;; wid-edit.el --- Functions for creating and using widgets -*- lexical-binding:t -*-
;;
;; Copyright (C) 1996-1997, 1999-2019 Free Software Foundation, Inc.
;;