Github/emacs
2
0
Fork 1
mirror of git://git.sv.gnu.org/emacs.git synced 2026-02-17 10:27:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

Nix some uses of eval

Browse source 
* lisp/play/dunnet.el: Fix triple negative.
(dun-doverb): Use funcall instead of eval.
(dun-echo): Just call dun-mprinc.
(dun-save-val): Just bind value without eval.
This commit is contained in:
Mark Oteiza 2017-01-17 00:48:00 -05:00
parent 922850bcc7
commit 5362ef79cb
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lisp/play/dunnet.el
View file

@ -1113,7 +1113,7 @@ for a moment, then straighten yourself up.
(dun-doverb dun-ignore dun-verblist (car rest) (cdr rest)))
(if (not (cdr (assq (intern verb) dun-verblist))) -1
(setq dun-numcmds (1+ dun-numcmds))
(eval (list (cdr (assq (intern verb) dun-verblist)) (quote rest)))))))
(funcall (cdr (assq (intern verb) dun-verblist)) rest)))))
;;; Function to take a string and change it into a list of lowercase words.
@ -2687,7 +2687,7 @@ drwxr-xr-x 3 root staff 2048 Jan 1 1970 ..")
(dun-mprinc var)
(dun-mprinc ": Permission denied")
(setq nomore t))
(eval (list 'dun-mprinc var))
(dun-mprinc var)
(dun-mprinc " ")))))))
(dun-mprinc "\n")))
@ -3177,9 +3177,7 @@ File not found")))
(defun dun-save-val (varname)
(let (value)
(setq varname (intern varname))
(setq value (eval varname))
(let ((value (symbol-value (intern varname))))
(dun-minsert "(setq ")
(dun-minsert varname)
(dun-minsert " ")
@ -3329,7 +3327,7 @@ File not found")))
(dun-mprinc "\n")
(dun-batch-loop))
(unless (not noninteractive)
(when noninteractive
(fset 'dun-mprinc 'dun-batch-mprinc)
(fset 'dun-mprincl 'dun-batch-mprincl)
(fset 'dun-vparse 'dun-batch-parse)