Github/emacs
2
0
Fork 1
mirror of git://git.sv.gnu.org/emacs.git synced 2026-06-14 12:31:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add tests for erc-track-faces-normal-list regression

Browse source 
* test/lisp/erc/erc-track-tests.el
(erc-track-tests--modified-channels/baseline): Update assertion to
expect an unchanged mode line segment if `erc-track-faces-normal-list'
lacks a ranked face in the latest inserted message.
(erc-track-modified-channels/baseline/nonotice)
(erc-track-modified-channels/priority-only-all/baseline/nonotice): New
tests.  (Bug#80659)
This commit is contained in:
F. Jason Park 2026-03-22 21:56:23 -07:00
parent 52e5dbd2da
commit 7b8a38e053
1 changed files with 26 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
test/lisp/erc/erc-track-tests.el
View file

@ -478,12 +478,28 @@
(funcall set-faces '(erc-notice-face))
(erc-track-modified-channels)
(should (equal (alist-get (current-buffer) erc-modified-channels-alist)
'(5 . erc-notice-face))))
(if (gethash 'erc-notice-face erc-track--normal-faces)
'(5 . erc-notice-face)
'(5 erc-button-nick-default-face erc-nick-default-face)))))
(ert-deftest erc-track-modified-channels/baseline ()
(erc-tests-common-track-modified-channels
#'erc-track-tests--modified-channels/baseline))
;; This "baseline" variant simulates `erc-notice-face' being absent from
;; `erc-track-faces-normal-list' by removing it from the cached local
;; copy in `erc-track--normal-faces'. When absent and a message
;; highlighted in `erc-notice-face' is inserted, the mode line should
;; not change if it's currently showing a face ranked higher in
;; `erc-track-faces-priority-list'. ERC 5.6 and 5.6.1 featured a
;; regression that caused the mode line to keep alternating regardless.
;; See Bug#80659: erc: Faces not being updated correctly.
(ert-deftest erc-track-modified-channels/baseline/nonotice ()
(erc-tests-common-track-modified-channels
(lambda (set-faces)
(remhash 'erc-notice-face erc-track--normal-faces)
(funcall #'erc-track-tests--modified-channels/baseline set-faces))))
(ert-deftest erc-track-modified-channels/baseline/mention ()
(erc-tests-common-track-modified-channels
(lambda (set-faces)
@ -613,6 +629,15 @@
(erc-tests-common-track-modified-channels
#'erc-track-tests--modified-channels/baseline)))
;; Option `erc-track-priority-faces-only' does not affect Bug#80659 (see
;; baseline test without the option above).
(ert-deftest erc-track-modified-channels/priority-only-all/baseline/nonotice ()
(let ((erc-track-priority-faces-only 'all))
(erc-tests-common-track-modified-channels
(lambda (set-faces)
(remhash 'erc-notice-face erc-track--normal-faces)
(funcall #'erc-track-tests--modified-channels/baseline set-faces)))))
;; This test simulates a common configuration that combines an
;; `erc-track-faces-priority-list' removed of `erc-notice-face' with
;; `erc-track-priority-faces-only' being `all'. It also features in the