Github/emacs
2
0
Fork 1
mirror of git://git.sv.gnu.org/emacs.git synced 2026-02-16 17:24:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix bug with an attempt to select uninitialized frame (Bug#18161).

Browse source 
* xfns.c (Fx_create_frame): Move call to change_frame_size to
a section where Lisp evaluation is disabled.  This way a pointer
to uninitialized frame is not accessible from Lisp, which becomes
critical if following call to x_figure_window_size throws an error.
This commit is contained in:
Dmitry Antipov 2014-08-03 11:19:43 +04:00
parent f91d04c6fe
commit a270fa7cf8
2 changed files with 27 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/ChangeLog
View file

@ -1,3 +1,11 @@
2014-08-03 Dmitry Antipov <dmantipov@yandex.ru>
Fix bug with an attempt to select uninitialized frame (Bug#18161).
* xfns.c (Fx_create_frame): Move call to change_frame_size to
a section where Lisp evaluation is disabled. This way a pointer
to uninitialized frame is not accessible from Lisp, which becomes
critical if following call to x_figure_window_size throws an error.
2014-08-02 Paul Eggert <eggert@cs.ucla.edu>
Fix bug with clang + directory_files_internal + GC (Bug#16986).

39
src/xfns.c
View file

@ -2884,7 +2884,7 @@ This function is an internal primitive--use `make-frame' instead. */)
int minibuffer_only = 0;
long window_prompting = 0;
int width, height;
ptrdiff_t count = SPECPDL_INDEX ();
ptrdiff_t count = SPECPDL_INDEX (), count2;
struct gcpro gcpro1, gcpro2, gcpro3, gcpro4;
Lisp_Object display;
struct x_display_info *dpyinfo = NULL;
@ -3130,6 +3130,14 @@ This function is an internal primitive--use `make-frame' instead. */)
end up in init_iterator with a null face cache, which should not
happen. */
init_frame_faces (f);
/* Temporary disable window-configuration-change-hook to avoid
an infloop in next_frame and access to uninitialized frame
from Lisp code (Bug#18161). */
count2 = SPECPDL_INDEX ();
record_unwind_protect (unwind_create_frame_1, inhibit_lisp_code);
inhibit_lisp_code = Qt;
/* PXW: This is a duplicate from below. We have to do it here since
otherwise x_set_tool_bar_lines will work with the character sizes
@ -3145,27 +3153,18 @@ This function is an internal primitive--use `make-frame' instead. */)
/* Set the menu-bar-lines and tool-bar-lines parameters. We don't
look up the X resources controlling the menu-bar and tool-bar
here; they are processed specially at startup, and reflected in
the values of the mode variables.
the values of the mode variables. */
Avoid calling window-configuration-change-hook; otherwise we
could get an infloop in next_frame since the frame is not yet in
Vframe_list. */
{
ptrdiff_t count2 = SPECPDL_INDEX ();
record_unwind_protect (unwind_create_frame_1, inhibit_lisp_code);
inhibit_lisp_code = Qt;
x_default_parameter (f, parms, Qmenu_bar_lines,
NILP (Vmenu_bar_mode)
? make_number (0) : make_number (1),
NULL, NULL, RES_TYPE_NUMBER);
x_default_parameter (f, parms, Qtool_bar_lines,
NILP (Vtool_bar_mode)
? make_number (0) : make_number (1),
NULL, NULL, RES_TYPE_NUMBER);
x_default_parameter (f, parms, Qmenu_bar_lines,
NILP (Vmenu_bar_mode)
? make_number (0) : make_number (1),
NULL, NULL, RES_TYPE_NUMBER);
x_default_parameter (f, parms, Qtool_bar_lines,
NILP (Vtool_bar_mode)
? make_number (0) : make_number (1),
NULL, NULL, RES_TYPE_NUMBER);
unbind_to (count2, Qnil);
}
unbind_to (count2, Qnil);
x_default_parameter (f, parms, Qbuffer_predicate, Qnil,
"bufferPredicate", "BufferPredicate",