Downgrading old fixmes to todos with better explanation of tasks.

mps/code/arenavm.c

@@ -183,7 +183,7 @@ static Bool VMArenaCheck(VMArena vmArena)
   CHECKD(Land, VMArenaSpareLand(vmArena));
   CHECKL((LandSize)(VMArenaSpareLand(vmArena)) == arena->spareCommitted);
 
-  /* FIXME: Can't check VMParams */
+  /* TODO: Add sig to VMParamsStruct so it can be checked. */
 
   return TRUE;
 }

mps/code/arg.c

@@ -65,7 +65,9 @@ Bool ArgCheckPoolDebugOptions(Arg arg)
 
 Bool ArgCheckFun(Arg arg)
 {
-  CHECKL(FUNCHECK(arg->val.addr_method)); /* FIXME: Potential pun here */
+  /* TODO: Fix potential pun here on Harvard architectures where
+     function pointers are not compatible with other pointers. */
+  CHECKL(FUNCHECK(arg->val.addr_method));
   return TRUE;
 }
 

mps/code/buffer.c

@@ -357,7 +357,8 @@ void BufferFinish(Buffer buffer)
   AVERT(Buffer, buffer);
   AVER(BufferIsReady(buffer));
 
-  BufferDetach(buffer, BufferPool(buffer)); /* FIXME: Should be in BufferAbsFinish? */
+  /* TODO: Consider whether this could move to BufferAbsFinish. */
+  BufferDetach(buffer, BufferPool(buffer));
 
   Method(Inst, buffer, finish)(MustBeA(Inst, buffer));
 }

mps/code/config.h

@@ -393,7 +393,7 @@
 
 
 /* Pool MVT Configuration -- see <code/poolmv2.c> */
-/* FIXME: These numbers were lifted from mv2test and need thought. */
+/* TODO: These numbers were lifted from mv2test and need thought. */
 
 #define MVT_ALIGN_DEFAULT         MPS_PF_ALIGN
 #define MVT_MIN_SIZE_DEFAULT      MPS_PF_ALIGN

mps/code/prmcxc.h

@@ -26,8 +26,8 @@ typedef struct MutatorContextStruct {
   Addr address;                 /* Fault address, if stopped by protection
                                  * fault; NULL if stopped by thread manager. */
   THREAD_STATE_S *threadState;
-  /* FIXME: Might need to get the floats in case the compiler stashes
-     intermediate values in them. */
+  /* TODO: Consider getting the floats in case the compiler stashes
+     intermediate values in them.  Never observed. */
 } MutatorContextStruct;
 
 extern void MutatorContextInitFault(MutatorContext context, Addr address, THREAD_STATE_S *threadState);

mps/code/splay.c

@@ -1237,7 +1237,7 @@ Bool SplayFindFirst(Tree *nodeReturn, SplayTree splay,
   while (!found) {
     Tree oldRoot, newRoot;
 
-    /* FIXME: Rename to "seen" and "not yet seen" or something. */
+    /* TODO: Rename to "seen" and "not yet seen" or something. */
     oldRoot = SplayTreeRoot(splay);
     newRoot = TreeRight(oldRoot);
 

mps/code/vmw3.c

@@ -67,6 +67,8 @@ Size PageSize(void)
 
 
 typedef struct VMParamsStruct {
+  /* TODO: Add sig and check with AVERT in VMInit and CHECKD in
+     VMArenaCheck. */
   Bool topDown;
 } VMParamsStruct, *VMParams;
 
@@ -101,7 +103,7 @@ Res VMInit(VM vm, Size size, Size grainSize, void *params)
   AVER(vm != NULL);
   AVERT(ArenaGrainSize, grainSize);
   AVER(size > 0);
-  AVER(params != NULL); /* FIXME: Should have full AVERT? */
+  AVER(params != NULL);
 
   AVER(COMPATTYPE(LPVOID, Addr));  /* .assume.lpvoid-addr */
   AVER(COMPATTYPE(SIZE_T, Size));

mps/example/scheme/scheme-advanced.c

@@ -4505,7 +4505,8 @@ int main(int argc, char *argv[])
   } MPS_ARGS_END(args);
   if (res != MPS_RES_OK) error("Couldn't create obj format");
 
-  /* Create a chain controlling GC strategy. FIXME: explain! */
+  /* Create a chain controlling GC strategy. */
+  /* TODO: Brief explanation with link to manual. */
   res = mps_chain_create(&obj_chain,
                          arena,
                          LENGTH(obj_gen_params),

mps/example/scheme/scheme.c

@@ -4442,7 +4442,8 @@ int main(int argc, char *argv[])
   } MPS_ARGS_END(args);
   if (res != MPS_RES_OK) error("Couldn't create obj format");
 
-  /* Create a chain controlling GC strategy. FIXME: explain! */
+  /* Create a chain controlling GC strategy. */
+  /* TODO: Brief explanation with link to manual. */
   res = mps_chain_create(&obj_chain,
                          arena,
                          LENGTH(obj_gen_params),