Github/emacs
2
0
Fork 1
mirror of git://git.sv.gnu.org/emacs.git synced 2026-06-14 04:21:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix the tab close button appearance when clicking (bug#76394)

Browse source 
* src/xdisp.c (handle_tab_bar_click): Use the variable 'close_p'
to show mouse face as sunken/raised only when clicked
on the close button.  Clicking elsewhere on the tab should not
change the close button's appearance using DRAW_MOUSE_FACE.
This commit is contained in:
Juri Linkov 2026-06-09 18:49:32 +03:00
parent a21614d4d6
commit c94d58ddbf
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/xdisp.c
View file

@ -15321,16 +15321,24 @@ handle_tab_bar_click (struct frame *f, int x, int y, bool down_p,
if (down_p) if (down_p)
{ {
/* Show the clicked button in pressed state. */ /* Show the clicked button in pressed state, but only when
the click was on the close button. Clicking elsewhere on
the tab should not change the close button's appearance,
so just keep the ordinary mouse-face highlight. */
if (!NILP (Vmouse_highlight)) if (!NILP (Vmouse_highlight))
show_mouse_face (hlinfo, DRAW_IMAGE_SUNKEN, true); show_mouse_face (hlinfo, close_p ? DRAW_IMAGE_SUNKEN : DRAW_MOUSE_FACE,
true);
f->last_tab_bar_item = prop_idx; /* record the pressed tab */ f->last_tab_bar_item = prop_idx; /* record the pressed tab */
} }
else else
{ {
/* Show item in released state. */ /* Show item in released state. Only change the close button's
appearance when the click was on it. Elsewhere keep the
ordinary mouse-face highlight to avoid the close button
blinking on release. */
if (!NILP (Vmouse_highlight)) if (!NILP (Vmouse_highlight))
show_mouse_face (hlinfo, DRAW_IMAGE_RAISED, true); show_mouse_face (hlinfo, close_p ? DRAW_IMAGE_RAISED : DRAW_MOUSE_FACE,
true);
f->last_tab_bar_item = -1; f->last_tab_bar_item = -1;
} }