From e09990891ffac9fa20385a8a38a18edf2e27d246 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Fri, 2 Jan 2026 07:45:14 +0100 Subject: [PATCH] ; * etc/themes/modus-themes.el: Update comment. See discussion here https://lists.gnu.org/archive/html/emacs-devel/2026-01/msg00011.html --- etc/themes/modus-themes.el | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/etc/themes/modus-themes.el b/etc/themes/modus-themes.el index 62a278e58ee..e61436e1cbc 100644 --- a/etc/themes/modus-themes.el +++ b/etc/themes/modus-themes.el @@ -4967,12 +4967,11 @@ If COLOR is unspecified, then return :box unspecified." `(compilation-warning ((,c :inherit modus-themes-bold :foreground ,warning))) ;;;;; completion-preview `(completion-preview ((,c :foreground ,fg-dim))) + ;; We set the following faces to inherit from `completion-preview', + ;; as they do by default. If we ever want them not to inherit from + ;; `completion-preview', then we should remember to customize + ;; `completion-preview-adapt-background-color' accordingly. `(completion-preview-common ((,c :inherit completion-preview :underline t))) - ;; NOTE 2025-11-18: We have to inherit `completion-preview' - ;; otherwise the `hl-line-mode' line loses its background where - ;; the `completion-preview-mode' overlay is. This is not - ;; intuitive, given that we do not set a background for - ;; `completion-preview'. `(completion-preview-exact ((,c :inherit (modus-themes-completion-match-0 completion-preview)))) ;;;;; completions `(completions-annotations ((,c :inherit modus-themes-slant :foreground ,docstring)))