Github/emacs
2
0
Fork 1
mirror of git://git.sv.gnu.org/emacs.git synced 2026-02-16 17:24:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

Adding references and clarifications in response to review <https://github.com/ravenbrook/mps/pull/214#discussion_r1230995545> and <https://github.com/ravenbrook/mps/pull/214#discussion_r1230997932>.

Browse source
This commit is contained in:
Richard Brooksby 2023-06-16 13:53:31 +01:00
parent e2a47c0a9f
commit ee37fb46ee
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
mps/code/trans.c
View file

@ -215,6 +215,8 @@ static Res transformFix(Seg seg, ScanState ss, Ref *refIO)
transform = ss->fixClosure;
AVERT_CRITICAL(Transform, transform);
/* .aborted: If the transform has been aborted, drop through to
normal GC fix, making the transform a normal GC. */
if (!transform->aborted) {
void *refNew;
@ -259,7 +261,7 @@ static void transformCondemn(void *closure, Word old, void *value)
/* Find segment containing old address. */
b = SegOfAddr(&seg, trace->arena, (Ref)old);
AVER(b); /* old refs must be in managed memory, else client param error */
AVER(b); /* should've been enforced by .old-white */
/* Condemn generation containing seg if not already condemned. */
gen = PoolSegPoolGen(SegPool(seg), seg)->gen;
@ -320,9 +322,12 @@ Res TransformApply(Bool *appliedReturn, Transform transform)
AVER(res == ResOK); /* transformFix can't fail */
/* If transformFix during traceFlip found ambiguous references and
aborted the transform then the rest of the trace is just a normal GC.
Note that aborting a trace part-way through is pretty much impossible
without corrupting the mutator graph. We could safely
aborted the transform then the rest of the trace is just a normal
GC (see .aborted). Note that aborting a trace part-way through
is pretty much impossible without corrupting the mutator graph.
We could optimise this safely at a later date if required, with::
if (transform->aborted) {
trace->fix = PoolFix;
trace->fixClosure = NULL;