From 189d6cb193ece226a4a9aa2d3a6f9a8af56d1940 Mon Sep 17 00:00:00 2001 From: Richard Brooksby Date: Tue, 26 Nov 2024 23:52:59 +0000 Subject: [PATCH 1/2] Removing unused variable that triggered the unused-but-set-variable warning when building on macos 14.7.1 with clang 15.0. --- mps/code/trans.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mps/code/trans.c b/mps/code/trans.c index 7e0f9ec196b..1ea5fb73cf2 100644 --- a/mps/code/trans.c +++ b/mps/code/trans.c @@ -151,7 +151,6 @@ Res TransformAddOldNew(Transform transform, { Res res; Index i; - Count added = 0; Arena arena; AVERT(Transform, transform); @@ -190,8 +189,6 @@ Res TransformAddOldNew(Transform transform, AVER(res != ResFAIL); /* It's a static error to add the same old twice. */ if (res != ResOK) return res; - - ++added; } AVERT(Transform, transform); From 028ac3804d1237fc2c9e25b28a2336889e37489a Mon Sep 17 00:00:00 2001 From: Richard Brooksby Date: Wed, 27 Nov 2024 12:49:13 +0000 Subject: [PATCH 2/2] Clarifying that two avers are implementing .assume.parked in response to review comment . --- mps/code/trans.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mps/code/trans.c b/mps/code/trans.c index 1ea5fb73cf2..3c7f83883e8 100644 --- a/mps/code/trans.c +++ b/mps/code/trans.c @@ -163,8 +163,8 @@ Res TransformAddOldNew(Transform transform, lists (old_list, new_list), using ArenaRead. Insisting on parking keeps things simple. */ arena = transform->arena; - AVER(ArenaGlobals(arena)->clamped); - AVER(arena->busyTraces == TraceSetEMPTY); + AVER(ArenaGlobals(arena)->clamped); /* .assume.parked */ + AVER(arena->busyTraces == TraceSetEMPTY); /* .assume.parked */ res = TableGrow(transform->oldToNew, count); if (res != ResOK)