Commit graph

70648 commits

Author SHA1 Message Date
Glenn Morris
1955afe0fc * lisp/gnus/gnus-cloud.el (gnus-cloud-synced-files): Fix doc & type. 2018-12-11 14:17:56 +08:00
Glenn Morris
5502f96b1a * lisp/ibuf-ext.el (ibuffer-never-search-content-mode): Fix type. 2018-12-11 14:17:56 +08:00
Glenn Morris
b74e19e759 * lisp/play/fortune.el (fortune-in-buffer): Revert previous nonsense. 2018-12-11 14:17:56 +08:00
Charles A. Roelli
91bdd5a4f0 Provide completion in vc-git-stash-* commands
* lisp/vc/vc-git.el (vc-git-stash-read-history)
(vc-git-stash-read): New history variable and function.
(vc-git-stash-show, vc-git-stash-apply, vc-git-stash-pop): Update
their interactive specifications.
2018-12-11 14:17:56 +08:00
Glenn Morris
e31b2771e7 * lisp/play/fortune.el (fortune-in-buffer): Unadvertise no-op arg. 2018-12-11 14:17:56 +08:00
Noam Postavsky
3b5438f388 Revert "Support all perl variable declarators and prefixes"
It highlights normal variable names in perl programs (Bug#30812).
* lisp/progmodes/perl-mode.el (perl-imenu-generic-expression)
(perl-font-lock-keywords-2): Restore values prior to Bug#27613 fix.

Don't merge to master, we will fix Bug#27613 properly there (it's too
close to release to do that on emacs-26).
2018-12-11 14:17:53 +08:00
Glenn Morris
45237016f7 * lisp/isearch.el (isearch-pre-command-hook): Replace cl-lib function.
As a preloaded file, isearch.el cannot require cl-lib at runtime.
2018-12-11 14:17:53 +08:00
Alan Mackenzie
7325e18625 * cc-engine.el (c-looking-at-or-maybe-in-bracelist): Remove pessimization 2018-12-11 14:17:53 +08:00
Aaron Jensen
98cca7258d Better support for 'transpose-chars' in Flyspell mode
* lisp/textmodes/flyspell.el (flyspell-post-command-hook): Check
word  before previous point location after 'transpose-chars'.
(Bug#30813)
2018-12-11 14:17:52 +08:00
Robert Pluim
f1168aa5f1 Correct Info link markup
* lisp/gnus/gnus-agent.el (gnus-agent-auto-agentize-methods):
Correct markup for Info link.
* src/minibuf.c (Fcompleting_read): Likewise.
2018-12-11 14:17:52 +08:00
Nick Helm
06a984e14e Improve documentation of 'with-help-window'
* doc/lispref/help.texi (Help Functions): Change variable name
to 'buffer-or-name'.

* lisp/help.el (with-help-window): Change variable name to
'buffer-or-name' and rewrite the doc string, adding reference
to 'help-window-setup'.  (Bug#30792)
2018-12-11 14:17:52 +08:00
Alex Branham
3b15508659 * lisp/textmodes/bibtex.el (bibtex-mark-entry): activate mark 2018-12-11 14:17:52 +08:00
Andrew G Cohen
751ecf3eb1 Set gnus-newsgroup-selection in the summary buffer
* lisp/gnus/nnselect.el (nnselect-retrieve-headers,
  nnselect-request-thread): Ensure that gnus-newsgroup-selection is
  set locally in the summary buffer.
2018-12-11 14:17:52 +08:00
Charles A. Roelli
fe4af1c543 Normalize and fix some mistakes in NS-related commentary
* lisp/term/ns-win.el (ns-insert-working-text): Normalize
commentary.
(x-file-dialog): Fix indentation.

* src/nsfns.m (ns_get_window, interpret_services_menu)
(x_set_background_color, x_set_icon_name, x_set_tool_bar_lines)
(x_set_icon_type, x_set_mouse_color, Fx_create_frame)
(ns_window_is_ancestor, Fns_popup_font_panel)
(Fx_display_visual_class, Fns_font_name, Fns_do_applescript)
(ns_screen_name, compute_tip_xy, Fns_mouse_absolute_pixel_position)
(handlePanelKeys): Normalize commentary (also in top-level
declarations) and remove two outdated comments (one in
Fx_create_frame, the other in compute_tip_xy).

* src/nsterm.h (NSApplication, NSWindow, ns_bitmap_record):
* src/nsselect.m:
* src/nsmenu.m (ns_update_menubar, addItemWithWidgetValue:)
(runMenuAt:forFrame:keymaps:, ns_menu_show, free_frame_tool_bar)
(update_frame_tool_bar, init)
(initWithContentRect:styleMask:backing:defer:)
(initFromContents:isQuestion:, timeout_handler:)
(Fmenu_or_popup_active_p):
* src/nsimage.m (initFromXBM, initFromXBMWithDepth):
* src/nsgui.h:
* src/nsfont.m (ns_spec_to_descriptor, ns_descriptor_to_entity)
(ns_charset_covers, ns_get_req_script, ns_findfonts)
(nsfont_list_family, nsfont_open, nsfont_encode_char)
(nsfont_draw, ns_uni_to_glyphs, ns_glyph_metrics)
(syms_of_nsfont): Normalize commentary (also in top-level
declarations).

* src/nsterm.m (ns_init_locale, ns_retain_object)
(ns_screen_margins_ignoring_hidden_dock, ns_unfocus, NSImageView)
(x_make_frame_visible, x_iconify_frame, x_destroy_window)
(x_set_undecorated, x_set_no_focus_on_map, x_set_z_group)
(ns_index_color, ns_get_color, ns_lisp_to_color)
(note_mouse_movement, scrollbar, ns_scroll_run)
(ns_draw_fringe_bitmap, ns_draw_window_cursor)
(ns_draw_text_decoration, ns_draw_relief)
(ns_dumpglyphs_box_or_relief, ns_dumpglyphs_image)
(ns_dumpglyphs_stretch, ns_draw_glyph_string, ns_send_appdefined)
(ns_check_menu_open, ns_read_socket, ns_select, ns_run_loop_break)
(ns_set_vertical_scroll_bar, ns_set_horizontal_scroll_bar)
(ns_string_to_lispmod, ns_default, ns_initialize_display_info)
(ns_delete_display, ns_term_init, sendEvent:)
(applicationDidFinishLaunching:, applicationDidBecomeActive:)
(fd_handler:, setWindowClosing:, keyDown:, insertText:)
(mouseDown:, mouseMoved:, updateFrameSize:)
(windowWillResize:toSize:, windowDidResize:, windowDidResignKey:)
(initFrameFromEmacs:, toggleFullScreen:, toolbarClicked:)
(writeSelectionToPasteboard:types:, setMiniwindowImage:)
(scrollerWidth, initFrame🪟, setFrame:, repeatScroll:)
(ns_xlfd_to_fontname, syms_of_nsterm): Normalize commentary (also in
top-level declarations), and in ns_get_color, replace a Gmane link
with one from lists.gnu.org, which does not require JS to view the
message.
2018-12-11 14:17:52 +08:00
Paul Eggert
d448a996d7 ; Spelling fix 2018-12-11 14:17:52 +08:00
Karl Fogel
b3c36c49b5 Revert move of interactive `transpose-regions' to Lisp
This reverts my commit 3a3aa0e056 of 2018-03-18 at 21:43:18 UTC.
I thought consensus had been reached, but it had not: Eli Zaretskii
felt the pre-3a3aa0e056a situation was fine and would not like to
see it changed without at least further discussion.
2018-12-11 14:17:52 +08:00
Michael Albinus
10794c813d Print top time consuming tests if advised
* lisp/emacs-lisp/ert.el (ert-summarize-tests-batch-and-exit):
New argument HIGH.  Print top-running tests.

* test/Makefile.in (check-doit): Use ${SUMMARIZE_TESTS}.

* test/README: Explain SUMMARIZE_TESTS.
2018-12-11 14:17:51 +08:00
Eli Zaretskii
ec18ff5cea Followup to last change in browse-url.el
* lisp/net/browse-url.el (browse-url-emacs): Doc fix to follow up
the previous change.  (Bug#30673)

* etc/NEWS: Mention the change in 'browse-url-emacs'.
2018-12-11 14:17:51 +08:00
Pierre Téchoueyres
1d789ecab2 Allow 'browse-url-emacs' to fetch URL in the selected window
* lisp/net/browse-url.el (browse-url-emacs): Use same-window argument.
(Bug#30673)
2018-12-11 14:17:51 +08:00
Radon Rosborough
31b6fa0a49 Various follow-ups for early init file changes
* doc/emacs/custom.texi (Early Init File): Add more details about
which variables must be set in the early init file rather than the
regular init file.  See
https://lists.nongnu.org/archive/html/bug-gnu-emacs/2018-02/msg00827.html

* lisp/emacs-lisp/package.el (package-enable-at-startup): Update
docstring to note that packages are now made available before loading
the init file, rather than afterwards.  See
https://lists.gnu.org/archive/html/emacs-devel/2018-02/msg00632.html
(package-load-list): Refer to "making available" rather than "loading"
for packages.  See
https://lists.gnu.org/archive/html/emacs-devel/2018-02/msg00298.html

* lisp/startup.el (command-line): Call `custom-reevaluate-setting' on
predefined variables before loading the early init file and before
`package-initialize' is called.  This prevents
`Info-default-directory-list' from being unbound when
`package-initialize' tries to access it during startup.  See
https://lists.gnu.org/archive/html/emacs-devel/2018-02/msg00545.html

* lisp/emacs-lisp/package.el (package-initialize): Issue a warning
if called twice.
See: https://lists.gnu.org/archive/html/emacs-devel/2018-02/msg00626.html
     https://lists.gnu.org/archive/html/emacs-devel/2018-03/msg00301.html
2018-12-11 14:17:51 +08:00
Basil L. Contovounesios
537ed97e9c Pass json-readtable-error data as a list (bug#30489)
* lisp/json.el (json-readtable-dispatch): Fix error data.
* test/lisp/json-tests.el (test-json-read): Check error data is a
list.
2018-12-11 14:17:51 +08:00
Glenn Morris
43af089d74 * lisp/url/url-handlers.el: No need for subr-x at run-time. 2018-12-11 14:17:51 +08:00
Karl Fogel
c5dd420116 Move interactive `transpose-regions' to Lisp
Define `transpose-regions' in Lisp, because its complex interactive
spec was ungainly in C, and change the C version to non-interactive
`transpose-regions-internal'.  The Lisp function is just a wrapper
around the C function, which still does all the work.

* lisp/simple.el (transpose-regions): New wrapper function, with
  interactive spec taken from old C `transpose-regions'.

* src/editfns.c (Ftranspose_regions): Rename to...
  (Ftranspose_regions_internal): ...here, and remove interactive spec.

Discussion on Emacs Devel:

  From: Karl Fogel
  To: Emacs Development
  Cc: Richard Copley, Charles A. Roelli
  Subject: Re: [Emacs-diffs] master b88e7c8: \
           Make transpose-regions interactive (Bug#30343)
  Date: Fri, 16 Mar 2018 10:23:31 -0500
  Message-ID: <87po44jb7w.fsf@red-bean.com>

  https://lists.gnu.org/archive/html/emacs-devel/2018-03/msg00555.html
2018-12-11 14:17:51 +08:00
Nicolas Petton
58da563239 * lisp/url/url-handlers.el: Require subr-x. 2018-12-11 14:17:51 +08:00
Nicolas Petton
a684aeb11e Add URL handler for file-name-directory (Bug#30444)
* lisp/url/url-handlers.el (url-handler-file-name-directory): New
function which handles special cases for `file-name-directory' and
URLs.
* test/lisp/url/url-handlers-test.el: New file.  Add tests for
`url-handler-file-name-directory'.
2018-12-11 14:17:51 +08:00
Michael Albinus
3a01434fb6 * lisp/emacs-lisp/ert.el (ert-run-tests-batch): Print selector. 2018-12-11 14:17:51 +08:00
Aaron Jensen
5224b57a87 In frameset save pixel values with frame-resize-pixelwise non-nil (Bug#30141)
* lisp/frameset.el (frameset--record-relationships): Replace
check for text width/height and replace with check for
frame-resize-pixelwise.  (Bug#30141)
2018-12-11 14:17:51 +08:00
Michael Albinus
08b32c91fc Print test timings unconditionally
* lisp/emacs-lisp/ert.el (ert-batch-print-duration): Remove.
(ert-run-tests-batch): Adapt accordingly.

* test/Makefile.in:
* test/README: Remove TEST_PRINT_TEST_DURATION.
2018-12-11 14:17:51 +08:00
Glenn Morris
9e3f6aa127 Explicitly require cl-lib where needed
Rather than relying on the byte-compiler happening to use it.
* lisp/completion.el, lisp/ffap.el, lisp/loadhist.el:
* lisp/userlock.el, lisp/emacs-lisp/debug.el, lisp/emacs-lisp/rx.el:
* lisp/emacs-lisp/testcover.el, lisp/mail/rfc2231.el:
* lisp/net/newst-treeview.el, lisp/net/puny.el:
* lisp/net/tramp-archive.el, lisp/net/tramp-gvfs.el:
* lisp/net/tramp-sh.el, lisp/net/tramp-smb.el, lisp/org/org-ctags.el:
* lisp/org/org-macs.el, lisp/progmodes/grep.el:
* lisp/progmodes/perl-mode.el, lisp/progmodes/ruby-mode.el:
* lisp/textmodes/dns-mode.el, lisp/textmodes/mhtml-mode.el:
* lisp/vc/pcvs-parse.el: Explicitly require cl-lib as needed.
2018-12-11 14:17:51 +08:00
Glenn Morris
118f691b06 cedet: remove obsolete name args to constructors
* lisp/cedet/ede/proj-archive.el, lisp/cedet/ede/proj-aux.el:
* lisp/cedet/ede/proj-elisp.el, lisp/cedet/ede/proj-info.el:
* lisp/cedet/ede/proj-misc.el, lisp/cedet/ede/proj-obj.el:
* lisp/cedet/ede/proj-shared.el, lisp/cedet/ede/simple.el:
* lisp/cedet/ede/source.el, lisp/cedet/semantic/:
* lisp/cedet/semantic/analyze.el, lisp/cedet/semantic/complete.el:
* lisp/cedet/semantic/db-javascript.el:
* lisp/cedet/semantic/db-ref.el, lisp/cedet/semantic/debug.el:
* lisp/cedet/semantic/ede-grammar.el:
* lisp/cedet/semantic/mru-bookmark.el, lisp/cedet/semantic/scope.el:
* lisp/cedet/semantic/texi.el, lisp/cedet/semantic/bovine/:
* lisp/cedet/semantic/bovine/c.el:
* lisp/cedet/semantic/bovine/debug.el, lisp/cedet/srecode/:
* lisp/cedet/srecode/extract.el, lisp/cedet/srecode/map.el:
* lisp/cedet/srecode/srt-mode.el:
Remove obsolete name args to constructors.
2018-12-11 14:17:51 +08:00
Noam Postavsky
e907e4a341 Improve word motion docs (Bug#30815)
* doc/lispref/positions.texi (Word Motion): Fix reference to
`char-script-table'.
* lisp/simple.el (backward-word):
* src/syntax.c (forward-word): Mention `char-script-table' and add
link to the 'Word Motion' manual section.
2018-12-11 14:17:51 +08:00
Glenn Morris
c5d9d8b844 Quieten semantic re-compilation when .elc already exist
* lisp/cedet/semantic/db-find.el, lisp/cedet/semantic/util.el:
Add some function declarations.
2018-12-11 14:17:51 +08:00
Glenn Morris
965f4ec9cc * lisp/gnus/gnus-registry.el: Add missing compile-time requirement. 2018-12-11 14:17:51 +08:00
Michael Albinus
23fb2521f4 Optimize "make check" and "make check-maybe"
* lisp/emacs-lisp/ert.el (ert-run-tests-batch): Print summary duration.

* test/Makefile.in (TEST_LOAD_EL): Set default to "no" for
targets all, check, and check-maybe.  (Bug#30807)

* test/README: Reflect recent changes in Makefile.

* test/lisp/net/tramp-archive-tests.el
(tramp-archive-test99-libarchive-tests): Tag it :unstable.
2018-12-11 14:17:50 +08:00
Reuben Thomas
82efded284 Call enchant-lsmod correctly when Enchant is installed with a suffix
* lisp/textmodes/ispell.el (ispell--call-enchant-lsmod): Cope with a
version suffix on the binary name, so enchant-2 is converted to
enchant-lsmod-2, not enchant-2-lsmod.
2018-12-11 14:17:50 +08:00
Glenn Morris
25950c11ca Suppress warnings about obsolete generics (bug#25556)
* lisp/Makefile.in (MAIN_FIRST): New variable.
(compile-main): Put some files at the head of the queue.
2018-12-11 14:17:50 +08:00
Glenn Morris
f5219ae241 Replace some obsolete uses of filter-buffer-substring-functions
* lisp/org/org-agenda.el (org-agenda-mode):
* lisp/org/org-indent.el (org-indent-mode):
Replace filter-buffer-substring-functions, obsolete since 24.4.
2018-12-11 14:17:50 +08:00
Glenn Morris
040f7253bc * lisp/emulation/cua-base.el (cua-paste): Quieten compilation. 2018-12-11 14:17:31 +08:00
Glenn Morris
620b63a366 * lisp/progmodes/verilog-mode.el (verilog-mode): Quieten compilation. 2018-12-11 14:17:31 +08:00
Glenn Morris
03e7331c59 * lisp/pcomplete.el (pcomplete-here): Move before first reference. 2018-12-11 14:17:30 +08:00
Michael Albinus
c6e52fa31e Improve robustness in tramp-sh.el
* lisp/net/tramp-sh.el (tramp-open-connection-setup-interactive-shell):
Wrap both echo calls in parentheses, in order to avoid double prompt.
2018-12-11 14:17:30 +08:00
Eli Zaretskii
dca8b75f74 Support variable-unquoting syntax in bat-mode
* lisp/progmodes/bat-mode.el (bat-font-lock-keywords): Fontify
argument numbers in %~n.  Suggested by Jostein Kjønigsen
<jostein@secure.kjonigsen.net> in emacs-devel.

* test/lisp/progmodes/bat-mode-tests.el
(bat-test-fontification-iter-var-1): Update the test to check also
the %~n construct.
2018-12-11 14:17:30 +08:00
Glenn Morris
64c4ec0379 More hydra.nixos.org logging for unfinished tests
* lisp/emacs-lisp/ert.el (ert-summarize-tests-batch-and-exit):
Dump contents of any unfinished log files on hydra.nixos.org.
2018-12-11 14:17:30 +08:00
Stefan Monnier
88a19e4419 * lisp/desktop.el: Make use some "new" functionality
(desktop-files-not-to-save, desktop-clear):
Use \` and \' when we don't intend to match newlines.
(desktop-minor-mode-table): Remove auto-fill-function entry.
(desktop-buffer-info): Use :minor-mode-function instead.
(desktop--v2s): Use a closure rather than a backquoted lambda.
(desktop-save): Set 'lexical-binding' in the saved file.
Use 'utf-8-emacs' encoding rather than the old 'emacs-mule'.
(desktop-read): Use 'default-value' to get the global part of a hook.
2018-12-11 14:17:30 +08:00
Michael Albinus
e3338f2933 Extend ert to print duration of single tests
* lisp/emacs-lisp/ert.el (ert-test-result): New slot ´duration'.
(ert-run-or-rerun-test): Set it.
(ert-batch-print-duration): New defvar.
(ert-run-tests-batch): Print duration if needed.

* test/Makefile.in (TEST_PRINT_TEST_DURATION): New variable.

* test/README: Explain TEST_PRINT_TEST_DURATION.
2018-12-11 14:17:30 +08:00
Noam Postavsky
77bf8e00b7 Fix line-wrapping for term.el (Bug#30775)
* lisp/term.el (term-emulate-terminal): Leave line-wrapping state if
point was moved after we entered it.
* test/lisp/term-tests.el (term-line-wrapping-then-motion): New test.
2018-12-11 14:17:30 +08:00
Glenn Morris
e274f0b23c Fix some allout.el aliases
* lisp/allout.el (allout-passphrase-verifier-string)
(allout-passphrase-hint-string): Fix alias.
2018-12-11 14:17:30 +08:00
Glenn Morris
16cfb9a6a1 * lisp/progmodes/ada-mode.el (ada-clean-buffer-before-saving): Doc fix. 2018-12-11 14:17:30 +08:00
Glenn Morris
aa527be770 Replace an obsolete alias in tpu-mapper
* lisp/obsolete/tpu-mapper.el (tpu-map-key, tpu-mapper):
Replace obsolete alias.
2018-12-11 14:17:30 +08:00
Glenn Morris
3b92c80680 * lisp/subr.el (focus-frame, unfocus-frame): Remove obsolete no-ops.
* lisp/vc/ediff-util.el (ediff-recenter):
Don't try focus-frame on Emacs.
; * etc/NEWS: Mention this.
; Comments in subr.el mention VM as a user, however this is untrue since
; 2010-07.  Ref https://bazaar.launchpad.net/~vm/vm/trunk/revision/840
; and 853.
2018-12-11 14:15:04 +08:00