Commit graph

44313 commits

Author SHA1 Message Date
Eli Zaretskii
1862df834c ; * src/search.c (Fmatch_data): Doc fix. 2022-10-30 19:57:14 +02:00
Manuel Giraud
efd3ef3ceb ; * src/window.c: Fix some comments. (Bug#58550) 2022-10-17 13:51:39 +03:00
Eli Zaretskii
fdb6f7cf26 ; Fix documentation of 'comp-enable-subr-trampolines'
* src/comp.c (syms_of_comp) <comp-enable-subr-trampolines>:
Explain better what it means to disable trampoline synthesis.
2022-10-15 12:15:17 +03:00
Andreas Schwab
a78af3018e * src/emacs.c (load_pdump): Propery handle case when executable
wasn't found.
2022-10-04 18:32:53 +02:00
Eli Zaretskii
b560ce3560 Avoid assertion violations in STRING_CHAR
* src/xdisp.c (handle_composition_prop):
* src/editfns.c (styled_format): Don't call 'STRING_CHAR' on
unibyte strings.  This avoids assertion violation in
'string_char_and_length'.

(cherry picked from commit d52d6e1e10)
2022-10-04 14:24:46 +03:00
Andreas Schwab
e5a49f44ff * src/emacs.c (load_pdump): Fix use of xpalloc. 2022-10-02 12:20:09 +02:00
Eli Zaretskii
7ff5207624 Avoid assertion violation in 'xpalloc'
* src/emacs.c (load_pdump): Ensure the 3rd argument of xpalloc is
always positive.  (Bug#58232)
2022-10-02 12:58:04 +03:00
Eli Zaretskii
b1e92c59ed Avoid assertion violations in 'pop_it'
* src/xdisp.c (pop_it): Avoid assertion violations when handling
lists or vectors of display properties.  (Bug#58122)
2022-09-28 16:46:39 +03:00
Eli Zaretskii
00159c086c ; Add commentary to disabled OTF support code in font.c
* src/font.c (check_gstring, check_otf_features, otf_tag_symbol)
(otf_open, font_otf_capability, generate_otf_features)
(font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
Move closer to the primitives that use them.  Add commentary for
the purpose of this code.
2022-09-26 09:35:10 +03:00
Eli Zaretskii
597c59078e ; * src/keyboard.c (Fposn_at_point): Doc fix. (Bug#52092) 2022-09-24 09:22:45 +03:00
YAMAMOTO Mitsuharu
60ac12d21f Fix shaping with bitmap-only fonts on HarfBuzz 5.2.0 (Bug#57976)
* src/ftcrfont.c (ftcrhbfont_begin_hb_font): Undo last change for
HarfBuzz 5.2.0.
2022-09-23 14:17:49 +09:00
Eli Zaretskii
10373c4b68 ; More comment fixes in font.h (bug#57935) 2022-09-19 18:58:25 +03:00
Manuel Giraud
c2595b8dcc ; * src/font.h (struct font_driver): Comment fix. 2022-09-19 18:56:39 +03:00
Eli Zaretskii
a2f9788cbc ; Minor copyedits of *-frame-alist doc strings
* src/frame.c (syms_of_frame) <default-frame-alist>:
* lisp/frame.el (initial-frame-alist): Minor doc fixes.
2022-09-18 20:21:58 +03:00
Eli Zaretskii
c200098dde ; * src/intervals.c (get_local_map): Fix commentary. 2022-09-18 19:59:58 +03:00
Eli Zaretskii
a5a92e577c ; * src/window.c (syms_of_window) <window-point-insertion-type>: Doc fix. 2022-08-29 17:09:02 +03:00
Eli Zaretskii
195fcc932e Improve the documentation of glyphless-character display
* lisp/international/characters.el (glyphless-char-display-control):
* src/xdisp.c (syms_of_xdisp) <glyphless-char-display>: Mention
the 'glyphless-char' face in the doc string.

* doc/lispref/display.texi (Glyphless Chars): Index
'glyphless-char' face.
2022-08-28 08:40:25 +03:00
Eli Zaretskii
3fb69fad49 Fix documentation of 'glyphless-char-display'
* src/xdisp.c (syms_of_xdisp)<glyphless-char-display>: Doc fix.
(gui_produce_glyphs, lookup_glyphless_char_display): Fix
indentation.
2022-08-27 10:50:57 +03:00
Alan Mackenzie
9c0eec4ed8 * src/window.c (select_window): Fix assert for buffer = non-active minibuffer 2022-08-19 15:06:38 +00:00
YAMAMOTO Mitsuharu
ae348b719e Fix wrong metrics for bitmap-only fonts with HarfBuzz 5
* src/ftcrfont.c (ftcrhbfont_begin_hb_font): Always use the standard
position unit value on HarfBuzz 5 and later regardless of whether the
font is bitmap-only or not.  (Bug#57066)
2022-08-11 18:16:24 +09:00
Eli Zaretskii
78759ddcb0 * src/lisp.h (CHECK_INTEGER): Fix the predicate. (Bug#56856) 2022-07-31 18:05:09 +03:00
Eli Zaretskii
eb11dae499 Improve documentation of column-related functions
* doc/lispref/text.texi (Primitive Indent, Columns):
* src/indent.c (Fcurrent_indentation, Fmove_to_column): Document
that column counting ignores invisible text.  (Bug#56837)
2022-07-30 19:34:38 +03:00
YAMAMOTO Mitsuharu
c95a34c960 * src/macfont.m (macfont_open): Initialize font->space_width. (Bug#56808) 2022-07-30 17:21:54 +09:00
Eli Zaretskii
970190b844 Avoid infloop in 'recenter'
* src/window.c (Frecenter): Avoid infinite loop in the minibuffer
under 'fido-vertical-mode'.  (Bug#56765)
2022-07-25 21:59:55 +03:00
Robert Pluim
04bdcf4aaa * src/terminal.c (Fframe_terminal): Use active voice 2022-07-22 14:19:04 +02:00
Robert Pluim
7fa491a9e9 Improve 'terminal-live-p' docstring some more
* terminal.c (Fterminal_live_p): Improve description of arguments and
return value.
2022-07-22 14:10:10 +02:00
Robert Pluim
b9ac8c29ae Improve terminal-live-p docstring
* src/terminal.c (Fterminal_live_p): Explain what happens when the
argument is nil.
2022-07-22 10:14:45 +02:00
Gerd Moellmann
f02944f5a1 Prevent GC of window referenced from EmacsScroller
* src/nsterm.m (EmacsScroller.mark, mark_nsterm): New functions.
* src/nsterm.h (EmacsScroller.mark, mark_nsterm): Declare.
* src/alloc.c (garbage_collect) [MAVE_NS]: Call mark_nsterm.
(Bug#56095)

(cherry picked from commit 5f1bd87247)
2022-07-19 16:04:13 +03:00
Eli Zaretskii
8f9993bb3f ; * src/buffer.c (syms_of_buffer) <mode-line-format>: Doc fix. 2022-07-18 15:31:26 +03:00
Stefan Kangas
ba0871bef1 ; Fix typos: prefer American spelling 2022-07-13 13:04:22 +02:00
Stefan Kangas
3442de2edd Doc fix; don't mention obsolete variable
* src/window.c (Fset_window_hscroll): Doc fix; don't mention obsolete
variable.
2022-07-08 21:16:00 +02:00
Brennan Vincent
7e33618bbc ; * src/fns.c (Frequire): Fix a typo in the doc string. (Bug#56328)
Copyright-paperwork-exempt: yes
2022-07-01 08:32:13 +03:00
Eli Zaretskii
2eb738f2b8 Support builds configured with a separate --bindir
* src/emacs.c (load_pdump): Don't overwrite the leading
directories of the Emacs executable just because the pdumper file
was not found in the expected directory relative to the binary.
This is needed to support builds with a separate --bindir
configure-time option and native-compilation.  (Bug#55741)
2022-06-20 19:04:06 +03:00
Robert Pluim
4d7a936ac2 ; * src/fileio.c (Fset_file_modes): Improve previous change 2022-06-15 15:16:47 +02:00
Robert Pluim
32cff740e2 Describe 'set-file-modes' argument prompting
* src/fileio.c (Fset_file_modes): Document that FILENAME is prompted
for.  (Bug#55984)
2022-06-15 14:27:28 +02:00
Jeff Walsh
8436e0bee9 Update error message to reflect variable rename
* src/comp.c (Fcomp_el_to_eln_filename): Update error message.  (Bug#55861)
2022-06-09 09:31:01 +03:00
Eli Zaretskii
ef5651cc77 Fix segfaults when starting on 80x26 TTY frames
* src/dispnew.c (adjust_frame_glyphs_for_frame_redisplay): Make
sure we have valid frame glyph matrices for the interactive
session.  (Bug#55760)
(adjust_frame_glyphs): Add assertions for when we fail to allocate
valid frame glyph matrices for a TTY frame.
2022-06-02 13:41:59 +03:00
Alan Mackenzie
f9ee83bfb9 do_switch_frame: before leaving mini-window, check other (mru) window is live
This fixes bug#55684.  There, with a minibuffer-only frame at start up,
Emacs tried to switch to this frame, whose selected window was the
mini-window.  There is no other active window in this frame, so the
attempt to swith to another window failed.

* src/frame.c (do_switch_frame): On switching to a frame whose selected
window is as above, before selecting the most recently used window, check
this ostensible window is an actual live window.  Otherwise leave the
mini-window selected.
2022-05-28 12:55:32 +00:00
Alan Mackenzie
dfa3e6f424 Restore the Fselect_window call in gui_consider_frame_title.
This fixes bug #55412.  The call to Fselect_window was removed on 2021-03-21
in the commit "Prevent open minibuffers getting lost when their frame gets
deleted".  This call is actually needed to determine current elements of the
pertinent window and frame when these are used in the frame title.

* src/frame.c (do_switch_frame): When the selected window in the target frame
is the mini-window, switch away from this window unless there is a valid
minibuffer there.

* src/frame.h (struct frame): Add an incidental comment about the element
selected_window.

* src/minibuf.c (move_minibuffers_onto_frame): No longer set the selected
window of the source frame.  This action is now performed later, on returning
to that frame, in do_switch_frame when needed (see above).

* src/xdisp.c (gui_consider_frame_title): Replace the Fselect_window call and
associated ancillary settings.
2022-05-20 20:18:38 +00:00
Stefan Kangas
5dbaddc729 ; Fix some typos 2022-05-15 11:05:36 +02:00
Lars Ingebrigtsen
936009cfe5 Be more resilient towards errors during error handling
* src/print.c (print_error_message): Avoid infinite recursion if
`substitute-command-keys' bugs out (bug#55269).

(cherry picked from commit 8364f058b8)
2022-05-05 20:05:28 +03:00
Eli Zaretskii
69c56cbe6e ; * src/w32notify.c: Fix a typo in a comment. 2022-05-05 10:38:40 +03:00
Eli Zaretskii
3b9e60ba2f ; * src/window.c (Fset_window_start): Mention the effect on vscroll. 2022-05-05 08:57:49 +03:00
Eli Zaretskii
3b6338c8c3 Improve documentation of font- and face-related attribute functions
* lisp/faces.el (face-attribute):
* src/xfaces.c (Fx_family_fonts):
* src/font.c (Ffont_get, Ffont_put): Improve and clarify the doc
strings.

* doc/lispref/display.texi (Low-Level Font): Document the :type
attribute of a font.  Improve documentation of 'font-get' and
'font-put'.
(Attribute Functions): Add cross-reference to the description of
face attributes.
2022-04-28 17:53:36 +03:00
Eli Zaretskii
1e9b9f403a Improve documentation of 'set-fontset-font'
* doc/lispref/display.texi (Fontsets):
* src/fontset.c (Fset_fontset_font): Improve and clarify the
documentation of 'set-fontset-font'.  Rename the arguments to be
more self-explanatory.  (Bug#55086)
2022-04-24 09:56:22 +03:00
Eli Zaretskii
d5728f129f Another fix for non-ASCII 'overlay-arrow-string'
* src/xdisp.c (get_overlay_arrow_glyph_row): Fix yet another place
that assumed each character is a single byte.
2022-04-22 09:05:57 +03:00
Eli Zaretskii
bf771e31bc ; * src/xdisp.c (get_overlay_arrow_glyph_row): Better var name. 2022-04-21 23:25:49 +03:00
Eli Zaretskii
5fe7e4d1ae Avoid a redisplay loop when 'overlay-arrow-string' is non-ASCII
* src/xdisp.c (get_overlay_arrow_glyph_row): Don't assume every
character in 'overlay-arrow-string' is one byte long.  Reported by
Yuri D'Elia <wavexx@thregr.org>.
2022-04-21 23:18:42 +03:00
Eli Zaretskii
c2f94f32b5 Revert "Don’t assume openat"
This reverts commit 3cccf0a910.

This is a change with far-reaching effects on MS-Windows at the least,
where file-related APIs are shadowed to support transparent support
for UTF-8 encoded file names.  Making such changes on a stable branch
for the benefit of a proprietary platform with a 13-year old OS is a
tail wagging the dog.  Please don't do that without discussing first.
2022-04-17 22:03:52 +03:00
Paul Eggert
3cccf0a910 Don’t assume openat
Use openat only on platforms with O_PATH.
This ports to OS X 10.9 and earlier.
Problem reported by Keith David Bershatsky in:
https://lists.gnu.org/r/emacs-devel/2022-04/msg00805.html
* lib-src/emacsclient.c (local_sockname): Use open, not openat.
* src/sysdep.c (sys_openat): New static function,
which uses openat only if O_PATH is defined.
(emacs_openat): Use it instead of openat.
(emacs_openat_noquit): Remove.
(emacs_open_noquit): Reimplement as per the old emacs_openat_noquit,
but use plain 'open'.
2022-04-17 10:43:13 -07:00