Commit graph

47991 commits

Author SHA1 Message Date
Eli Zaretskii
aed2b7a3d8 Avoid assertion violations in 'push_prefix_prop'
* src/xdisp.c (push_prefix_prop): Set the
'string_from_prefix_prop_p' flag for any valid value of the
'line-prefix' or 'wrap-prefix' property/variable.  (Bug#70495)
2024-04-21 16:06:34 +03:00
Eli Zaretskii
ea62a14ea3 Fix display of vscrolled windows
* src/xdisp.c (redisplay_window): Fix condition for resetting the
window's vscroll.  (Bug#70038)
2024-04-11 18:34:53 +03:00
Eli Zaretskii
2a41b6ba51 ; * src/filelock.c (Flock_file): Doc fix (bug#70216). 2024-04-07 09:24:58 +03:00
Eli Zaretskii
9d3d77f12d Fix documentation of 'other-window-for-scrolling'
* src/window.c (Fother_window_for_scrolling): More accurate
documentation of how "the other" window is looked for.  Suggested
by Karthik Chikmagalur <karthikchikmagalur@gmail.com>.
2024-03-25 15:12:42 +02:00
Basil L. Contovounesios
3b791ebbe1 ; Fix 'usage:' keyword in Ffile_name_concat doc. 2024-03-16 00:20:41 +01:00
Eli Zaretskii
b708e639d6 ; * src/lread.c (maybe_swap_for_eln): Clarify warning message. 2024-03-14 21:08:36 +02:00
Eli Zaretskii
6e801077ae ; * src/composite.c (composition_compute_stop_pos): Add comment. 2024-03-04 17:09:29 +02:00
Eli Zaretskii
ae80192d97 ; * src/buffer.c (Fmake_indirect_buffer): Doc fix. 2024-03-01 10:32:32 +02:00
Eli Zaretskii
383ccf6d51 Avoid assertion violations in bidi.c
* src/bidi.c (bidi_resolve_brackets): Move assertion about
'resolved_level' to where it belongs.  This avoids unnecessary
aborts when the character is not a bracket type and doesn't need
BPA resolution.  (Bug#69421)
2024-02-27 13:12:15 +02:00
Eli Zaretskii
c22d0ae2dd Fix "emacs -nw" on MS-Windows
* src/w32term.c (w32_flip_buffers_if_dirty): Do nothing if F is
not a GUI frame.  This avoids rare crashes in "emacs -nw".
* src/w32console.c (initialize_w32_display): Set the
ENABLE_EXTENDED_FLAGS bit in 'prev_console_mode'.

(cherry picked from commit e1970c99f0)
2024-01-28 16:50:49 +02:00
Gregory Heytings
53b5b77010 Simplify 'without-restriction'
This simplification is symmetrical to 01fb898420.

* src/editfns.c: (Finternal__labeled_widen): Add a call to
'Fwiden', and rename from 'internal--unlabel-restriction'.
(unwind_labeled_narrow_to_region): Use the renamed function, and
remove the call to 'Fwiden'.
(syms_of_editfns): Rename the symbol.

* lisp/subr.el (internal--without-restriction): Use the renamed
function.

(cherry picked from commit 9e9e11648d)
2024-01-15 13:26:28 +00:00
Gregory Heytings
5bb5590dec Fix blunder in labeled_narrow_to_region
* src/editfns.c (labeled_narrow_to_region): Record point before,
instead of after, calling narrow-to-region; otherwise point may
already have been changed.  Fixes bug#66764.
2024-01-14 21:59:21 +00:00
Andrea Corallo
9308d9a74a * src/comp.c (Fcomp__compile_ctxt_to_file): Fix hash table Qunbound use. 2024-01-04 11:15:13 +01:00
Eli Zaretskii
ab66b749a2 ; * src/window.c (Fset_window_margins): Doc fix. 2024-01-03 15:14:41 +02:00
Po Lu
8e1c56ae46 ; Add 2024 to copyright years 2024-01-02 09:47:10 +08:00
Yuan Fu
5303152872
Revert "Fix treesit-node-field-name and friends (bug#66674)"
This reverts commit 9874561f39.

See bug#67990.  Basically our original code is correct, the error is
in libtree-sitter, which only manifests in certain cases.

https://github.com/tree-sitter/tree-sitter/pull/2104
2023-12-29 19:52:07 -08:00
Eli Zaretskii
fa0bb88302 ; * src/buffer.c (syms_of_buffer) <default-directory>: Doc fix (bug#68088). 2023-12-28 21:46:59 +02:00
Yuan Fu
683c7c9687
Increment parser timestamp when narrowing changes (bug#67977)
When narrowing changes, parse reparses, so the timestamp should
definitely increment, just like in ts_record_changes.

Failing to increment this timestamp, outdated nodes would think they
are still up-to-date, and try to print their type name.  Printing
their type name involves accessing the old parse tree, which is
already freed during the last reparse.

I also found that we don't increment timestamp when changing parser
ranges and fixed that as well.

* src/treesit.c (treesit_sync_visible_region):
(Ftreesit_parser_set_included_ranges): Increment timestamp.
* src/treesit.h (Lisp_TS_Parser): Add some comments.
2023-12-23 18:43:51 -08:00
Eli Zaretskii
2922d683b7 ; * src/treesit.c (treesit_traverse_child_helper): Fix comment. 2023-12-19 18:53:18 +02:00
Denis Zubarev
7b315e8a5c
Fix an issue when searching subtree backward (bug#67117)
* src/treesit.c (treesit_traverse_child_helper):
Do not call treesit_traverse_sibling_helper when the named node is
required and the last child is the named node.
Otherwise treesit_traverse_sibling_helper will move cursor to the
previous sibling and last node will be skipped.
* test/src/treesit-tests.el (treesit-search-subtree-forward-1):
(treesit-search-subtree-backward-1):
Add tests.
2023-12-18 18:25:26 -08:00
Yuan Fu
9874561f39
Fix treesit-node-field-name and friends (bug#66674)
So turns out ts_node_field_name_for_child takes a named node index,
but we were passing it normal index that counts both named and
anonymous nodes.  That's what makes the field name all wrong in
treesit explorer.

* doc/lispref/parsing.texi:
(Accessing Node Information): Update docstring.
* lisp/treesit.el (treesit-node-index): Add some unrelated comment.
(treesit-node-field-name): Get named node index rather than all node
index.
* src/treesit.c (Ftreesit_node_field_name_for_child): Update
docstring, use ts_node_named_child_count.
2023-12-10 16:28:21 -08:00
Stefan Kangas
2773cf9e01 ; Fix typos 2023-12-10 12:39:54 +01:00
Stefan Kangas
020aff95fa ; Fix typos in ChangeLog files 2023-12-10 12:38:19 +01:00
Stefan Kangas
5f923ff1a6 ; Fix typos 2023-12-03 23:31:30 +01:00
Eli Zaretskii
7ff943044e Fix setting cursor when the window's op line has 'line-prefix'
* src/xdisp.c (set_cursor_from_row): Skip glyphs that come from a
string if their 'avoid_cursor_p' flag is set.  (Bug#67486)
2023-12-02 14:13:24 +02:00
Michael Albinus
4774a3abb4 Document, that PROCESS of signal-process can be a string
* doc/lispref/processes.texi (Signals to Processes) [signal-process]:
* src/process.c (Fsignal_process): Document, that PROCESS can be a
string.
2023-11-30 14:37:40 +01:00
Eli Zaretskii
3327f36ad9 Add 2 SQLite extensions to allow-list.
* src/sqlite.c (Fsqlite_load_extension): Add 2 Free Software
extensions to the allow-list.  For the details, see
https://lists.gnu.org/archive/html/emacs-devel/2023-11/msg00234.html.
2023-11-18 11:11:04 +02:00
Eli Zaretskii
42181b65df ; * src/editfns.c (Fline_beginning_position): Doc fix. 2023-11-16 11:30:48 +02:00
Eli Zaretskii
fe000236cf Improve documentation of signaling errors in batch mode
* doc/lispref/control.texi (Signaling Errors)
(Processing of Errors):
* doc/lispref/os.texi (Batch Mode):
* doc/lispref/debugging.texi (Invoking the Debugger):
* lisp/emacs-lisp/debug.el (debug):
* src/eval.c (Fsignal):
* lisp/subr.el (error): Document more prominently that signaling
an unhandled error in batch mode kills Emacs.  Better
documentation of backtrace in batch mode.
2023-11-09 10:33:28 +02:00
Stefan Kangas
aa253c533d ; Fix broken links to gmane.org 2023-10-24 09:44:01 +02:00
Po Lu
d9e1605122 Correctly register focus events concomitant with alpha changes
* src/xterm.c (x_frame_highlight, x_frame_unhighlight): Skip
changing the frame alpha when the frame is not eligible for
focus state-specific alpha values; otherwise, the alpha might be
reset by the time a alpha change wrought by a focus change
arrives, impeding handle_one_xevent from subsequently restoring
the initial value.  (bug#66398)
2023-10-17 08:33:25 +08:00
Eli Zaretskii
8f23a02a9e Fix updating process-mark position in 'set-process-buffer'
* src/process.c (update_process_mark): Update marker position only
if P's process-mark is not already associated with P's buffer.
(Bug#66313)
2023-10-07 17:58:54 +03:00
Eli Zaretskii
1594d5f17a Fix setting the pipe capacity for subprocesses
* src/process.c (create_process) [F_SETPIPE_SZ]: Set the pipe
capacity only if the required read-process-max is larger than the
default capacity of the pipe.  (Bug#66288)
2023-10-06 08:31:59 +03:00
Gerd Möllmann
aad8b5d78f Handle LANG on macOS differently (bug#65908)
* src/nsterm.m (ns_init_locale): If LANG is set, try to use that,
otherwise try to deduce what LANG should be.  Check is the result is
valid, and use LANG="en_US.UTF-8" if not.
2023-10-05 20:41:54 +02:00
Stefan Kangas
fa0d3f45ae ; Improve wording of last change
* doc/emacs/macos.texi (Mac / GNUstep Customization):
* src/nsfns.m (syms_of_nsfns): Improve wording.
Reported by Gerd Möllmann <gerd.moellmann@gmail.com>.
2023-10-01 18:27:11 +02:00
Stefan Kangas
3ef259e28a Improve documentation of ns-use-proxy-icon
* doc/emacs/macos.texi (Mac / GNUstep Customization):
* src/nsfns.m (syms_of_nsfns): Fix documentation of
'ns-use-proxy-icon'; explain what it does and how it's
used.  (Bug#66190)
2023-10-01 15:37:06 +02:00
Eli Zaretskii
d210d761b1 ; Fix doc strings of overlay-arrow variables
* src/xdisp.c (syms_of_xdisp) <overlay-arrow-string>
<overlay-arrow-variable-list>: Doc fixes.  (Bug#66282)
2023-10-01 08:08:03 +03:00
Eshel Yaron
a4185f87bd ; Silence macOS 14 warning
* src/nsterm.m: Implement 'applicationSupportsSecureRestorableState'
to silence warning on macOS 14.  (Bug#66245)
2023-09-29 13:32:55 +02:00
Eli Zaretskii
809305e6d8 Fix 'window-text-pixel-size' when there are several images at START
* src/xdisp.c (window_text_pixel_size): Remove unnecessary call to
'move_it_to'.  (Bug#65899)  (Bug#54862)
2023-09-14 12:52:14 +03:00
Stefan Monnier
0065621d0d (report_overlay_modification): Fix bug#65929
Somehow the new overlay code in Emacs-29 changed slightly
the test to decide when to run the `modification-hooks` of overlays,
with the consequence that these hook functions end up being executed
also when text is deleted right after an empty overlay, which is
contrary to Emacs-28 behavior as well as contrary to the Texinfo doc.

* src/buffer.c (report_overlay_modification): Better reproduce the
Emacs-28 code.

* test/src/buffer-tests.el (overlay-modification-hooks):
Add corresponding test.
2023-09-13 18:49:55 -04:00
Alan Third
6cc6455e93 Fix SVG colors (bug#56182)
* src/image.c (svg_load_image): Reverse the R and B bytes in the
Windows colors before using them to generate the SVG.
2023-09-13 20:19:44 +01:00
Yuan Fu
33ee3e588f
Fix regression of treesit_cursor_helper_1
* src/treesit.c (treesit_cursor_helper_1)
(treesit_cursor_first_child_for_byte): Use
ts_tree_cursor_goto_first_child_for_byte first, and
ts_tree_cursor_goto_first_child second.
2023-09-11 12:50:31 -07:00
Eli Zaretskii
3f04efe9e7 ; * src/font.h (struct font): Comment about use of average_width. 2023-09-10 18:31:06 +03:00
Philipp Stephani
1a668cda8b Unbreak builds with CHECK_STRUCTS.
* src/pdumper.c (dump_buffer): Fix hash for 'struct buffer'.  The
recent changes to that structure where commits
8f3091defb and
0bd4661941, both of which just affected
comments.
2023-09-07 11:33:37 +02:00
Daniel Martín
1458daf316 Avoid crashes on macOS with context menus
* src/nsmenu.m ([EmacsMenu menuNeedsUpdate:]): Avoid crashes with
context menus.  (Bug#63495)
2023-09-07 08:21:38 +03:00
Stefan Monnier
6fad73d7cc * src/regex-emacs.c (mutually_exclusive_p): Fix inf-loop (bug#65726) 2023-09-04 13:11:31 -04:00
Stefan Kangas
3550f44c17 ; Fix typos 2023-09-02 18:57:11 +02:00
Stefan Kangas
0bd4661941 Doc fixes for obsolete functions and variables
* admin/notes/multi-tty:
* doc/emacs/building.texi (Debugger Operation):
* doc/misc/efaq-w32.texi (Line ends by file system):
* doc/misc/gnus.texi (Hashcash):
* lisp/emacs-lisp/eieio.el (eieio-class-parents)
(eieio-class-children):
* lisp/progmodes/perl-mode.el:
* lisp/textmodes/ispell.el (ispell-lookup-words):
* src/buffer.h: Update or delete references to variables and functions
made obsolete in Emacs 24.4.
2023-09-02 15:37:08 +02:00
Eli Zaretskii
5cbe96d17f ; Improve documentation of 'char-table-range'
* doc/lispref/sequences.texi (Char-Tables):
* src/chartab.c (Fchar_table_range): Clarify what
'char-table-range' returns for an argument that is a cons cell.
2023-09-01 16:33:40 +03:00
Yuan Fu
18b292140e
; * src/treesit.c: Add ts function boilerplate 2023-08-31 16:00:54 -07:00