mirror of
git://git.sv.gnu.org/emacs.git
synced 2026-02-18 02:47:36 +00:00
6ff870218d
This catches some problems with integer overflow and races that I noticed in inotify.c after reviewing the changes installed to fix Bug#26126. * src/fns.c, src/lisp.h (equal_no_quit): Now extern. * src/inotify.c (aspect_to_inotifymask): Check for cycles and for improper lists. (make_lispy_mask, lispy_mask_match_p): Remove. All callers changed to use INTEGER_TO_CONS and CONS_TO_INTEGER. (inotifyevent_to_event, add_watch): Don’t assume watch descriptors and cookies fit in fixnums. (add_watch): Use assoc_no_quit, not Fassoc. Avoid integer overflow in (very!) long-running processes where the Emacs watch ID could overflow. Avoid some duplicate code. (find_descriptor): New function. (remove_descriptor): First arg is now the returned value from find_descriptor, rather than the descriptor. This way, the value can be removed without calling Fdelete, which might quit. Wait until the end (when watch_list is consistent) before signaling any errors. (remove_watch, inotify_callback): Use find_descriptor to avoid the need for Fdelete. (inotify_callback): Use simpler tests for ioctl failure. Free temporary buffer if signaled, and put it on the stack if small. Use ssize_t to index through read results, to avoid a cast. (valid_watch_descriptor): New function, with a tighter check. (Finotify_rm_watch, Finotify_valid_p): Use it. (Finotify_valid_p): Use assoc_no_quit and ass_no_quit instead of Fassoc. Do not assume the first assoc succeeds. * test/src/inotify-tests.el (inotify-valid-p-simple): Add inotify-valid-p tests, some of which dump core without the fixes noted above. |
||
|---|---|---|
| .. | ||
| data | ||
| lisp | ||
| manual | ||
| src | ||
| ChangeLog.1 | ||
| file-organization.org | ||
| make-test-deps.emacs-lisp | ||
| Makefile.in | ||
| README | ||
Copyright (C) 2008-2017 Free Software Foundation, Inc. See the end of the file for license conditions. This directory contains files intended to test various aspects of Emacs's functionality. Please help add tests! See the file file-organization.org for the details of the directory structure and file-naming conventions. Emacs uses ERT, Emacs Lisp Regression Testing, for testing. See (info "(ert)") or https://www.gnu.org/software/emacs/manual/html_node/ert/ for more information on writing and running tests. The Makefile in this directory supports the following targets: * make check Run all tests as defined in the directory. Expensive tests are suppressed. The result of the tests for <filename>.el is stored in <filename>.log. * make check-maybe Like "make check", but run only the tests for files which have unresolved prerequisites. * make check-expensive Like "make check", but run also the tests marked as expensive. * make <filename> or make <filename>.log Run all tests declared in <filename>.el. This includes expensive tests. In the former case the output is shown on the terminal, in the latter case the output is written to <filename>.log. ERT offers selectors, which make it possible to filter out which test cases shall run. The make variable $(SELECTOR) gives you a simple mean to use your own selectors. The ERT manual describes how selectors are constructed, see (info "(ert)Test Selectors") or https://www.gnu.org/software/emacs/manual/html_node/ert/Test-Selectors.html You could use predefined selectors of the Makefile. "make <filename> SELECTOR='$(SELECTOR_DEFAULT)'" runs all tests for <filename>.el except the tests tagged as expensive. If your test file contains the tests "test-foo", "test2-foo" and "test-foo-remote", and you want to run only the former two tests, you could use a selector regexp: "make <filename> SELECTOR='\"foo$$\"'". (Also, see etc/compilation.txt for compilation mode font lock tests.) This file is part of GNU Emacs. GNU Emacs is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. GNU Emacs is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.