From 1ba69a10a6891c9357d2d1a718111b4cb2f970d5 Mon Sep 17 00:00:00 2001 From: Benson Chu Date: Fri, 30 Dec 2022 17:27:19 -0600 Subject: [PATCH] Fixed that bug --- lisp/llvm-lib/llvm-act-on-file/act-on-c-file.el | 1 - lisp/llvm-lib/my-comp-minor-mode.el | 14 ++++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/lisp/llvm-lib/llvm-act-on-file/act-on-c-file.el b/lisp/llvm-lib/llvm-act-on-file/act-on-c-file.el index 562dd84..00e31b9 100644 --- a/lisp/llvm-lib/llvm-act-on-file/act-on-c-file.el +++ b/lisp/llvm-lib/llvm-act-on-file/act-on-c-file.el @@ -127,7 +127,6 @@ (make-variable-buffer-local 'compilation-error-regexp-alist) (setq compilation-error-regexp-alist nil)) - ;; TODO: This doesn't ACTUALLY survive a call to #'recompile (make-variable-buffer-local 'compilation-finish-functions) (add-to-list 'compilation-finish-functions #'ll/c-file-sentinel))))) diff --git a/lisp/llvm-lib/my-comp-minor-mode.el b/lisp/llvm-lib/my-comp-minor-mode.el index 2543b64..97bbe7c 100644 --- a/lisp/llvm-lib/my-comp-minor-mode.el +++ b/lisp/llvm-lib/my-comp-minor-mode.el @@ -37,10 +37,16 @@ commands of Compilation major mode are available. See (compilation--unsetup))) (defun my/enable-comp-keys-if-separate-mode (orig &rest args) - (aprog1 (apply orig args) - (when (cadr args) - (with-current-buffer it - (compilation-minor-mode))))) + (let ((hook compilation-finish-functions)) + (aprog1 (apply orig args) + (when (cadr args) + (with-current-buffer it + (compilation-minor-mode)) + + (setq-local compilation-finish-functions + (seq-uniq + (append compilation-finish-functions + hook))))))) (advice-add #'compilation-start :around