Puppet helped me find a bug!

WAIT behavior is now more consistent

lisp/org-config/my-org-agenda-commands.el

@@ -258,7 +258,7 @@
 
   (setq org-agenda-custom-commands
         `(("p" . "\tprod")
-          ,@(agenda-suite "all" "pa" "time")
+          ,@(agenda-suite "all" "pa" "prod")
           ,@(agenda-suite "school" "ps" "time")
           ,@(agenda-suite "family" "pf" "time")
           ,@(agenda-suite "dev" "d" "dev")

lisp/org-project/opr-tasks.el

@@ -63,7 +63,7 @@
       ("WAIT" (if (when-let (d (org-entry-get (point) "SCHEDULED"))
                     (org-time> d (org-matcher-time "<today>")))
                   'wait-active ;; BENSON_UPDATE_THIS: Change this to active?
-                'wait))
+                'stuck))
       (_ (when (or (member state opr/strict-tasks)
                    (and (member state opr/ambiguous)
                         (eq 'task

tests/files/meta-stuck-base.org

@@ -13,3 +13,7 @@
 * META should be stuck even if there are deadlined dones
 ** DONE Deadlined done task
 DEADLINE: <2021-06-21 Mon>
+* META should be stuck if there are past-due waiting tasks
+** WAIT for this to happen
+SCHEDULED: <1970-01-01 Thu>
+- State "WAIT"       from              [2022-09-29 Thu 16:53]

tests/files/wait-active.org

@@ -0,0 +1,3 @@
+
+* WAIT Waiting tasks, when they are scheduled in the future, are wait-active
+SCHEDULED: <2037-01-01 Thu>

tests/files/wait-stuck.org

@@ -0,0 +1,5 @@
+
+* WAIT tasks are stuck if there is no schedule
+
+* WAIT tasks are stuck if their scheduled date has passed
+SCHEDULED: <1970-01-01 Thu>

tests/my-org-tests.el

@@ -67,6 +67,12 @@
   (should (null (my/org-agenda-skip-unless-prod-tag)))
   (should (not (null (my/org-agenda-skip-unless-dev-tag)))))
 
+(org-test/parents-should "wait-stuck.org"
+  (should (eq 'stuck (opr/type-of-task))))
+
+(org-test/parents-should "wait-active.org"
+  (should (eq 'wait-active (opr/type-of-task))))
+
 (ert-run-tests-interactively t)
 
 ;; (progn (setq org-disabled-tests nil) (mapcar (lambda (sym) (put sym 'ert--test nil)) (apropos-internal "" #'ert-test-boundp)))