Fix interactive forms in some Lisp packages

* lisp/woman.el (woman-reset-emulation):
* lisp/treesit.el (treesit--explorer-jump):
* lisp/speedbar.el (speedbar-toggle-etags):
* lisp/filesets.el (filesets-convert-patterns):
* lisp/calculator.el (calculator-saved-move):
* lisp/progmodes/gud.el (gud-basic-call):
* lisp/progmodes/ebrowse.el (ebrowse-redraw-marks)
(ebrowse-view-file-other-frame):
* lisp/progmodes/dcl-mode.el (dcl-indent-to):
* lisp/net/socks.el (socks-open-connection):
* lisp/net/ntlm.el (ntlm-build-auth-request):
* lisp/emacs-lisp/backtrace.el (backtrace-expand-ellipsis):
* lisp/calc/calc-prog.el (calc-edit-macro-finish-edit):
* lisp/calc/calc-misc.el (calc-info-goto-node):
* lisp/net/dictionary.el (dictionary-new-search)
(dictionary-definition, dictionary-switch-tooltip-mode): Fix
interactive functions where the 'interactive' form did not supply
the mandatory arguments.  (Bug#62864)
This commit is contained in:
Eli Zaretskii 2023-05-06 11:29:58 +03:00
parent f261226d9b
commit 9b66a64d9c
14 changed files with 9 additions and 21 deletions

View file

@ -195,7 +195,6 @@ Calc user interface as before (either \\`C-x * C' or \\`C-x * K'; initially \\`C
;;;###autoload ;;;###autoload
(defun calc-info-goto-node (node) (defun calc-info-goto-node (node)
"Go to a node in the Calculator info documentation." "Go to a node in the Calculator info documentation."
(interactive)
(select-window (get-largest-window)) (select-window (get-largest-window))
(info (concat "(Calc)" node))) (info (concat "(Calc)" node)))

View file

@ -936,7 +936,6 @@
(defun calc-edit-macro-finish-edit (cmdname key) (defun calc-edit-macro-finish-edit (cmdname key)
"Finish editing a Calc macro. "Finish editing a Calc macro.
Redefine the corresponding command." Redefine the corresponding command."
(interactive)
(let ((cmd (intern cmdname))) (let ((cmd (intern cmdname)))
(calc-edit-macro-pre-finish-edit) (calc-edit-macro-pre-finish-edit)
(let* ((str (buffer-substring calc-edit-top (point-max))) (let* ((str (buffer-substring calc-edit-top (point-max)))

View file

@ -1349,8 +1349,9 @@ Optional string argument KEYS will force using it as the keys entered."
(calculator-update-display t)) (calculator-update-display t))
(defun calculator-saved-move (n) (defun calculator-saved-move (n)
"Go N elements up the list of saved values." "Go N elements up the list of saved values.
(interactive) Interactively, N is the prefix numeric argument and defaults to 1."
(interactive "p")
(when (and calculator-saved-list (when (and calculator-saved-list
(or (null calculator-stack) calculator-display-fragile)) (or (null calculator-stack) calculator-display-fragile))
(setq calculator-saved-ptr (setq calculator-saved-ptr

View file

@ -499,7 +499,6 @@ Reprint the frame with the new view plist."
(defun backtrace-expand-ellipsis (button) (defun backtrace-expand-ellipsis (button)
"Expand display of the elided form at BUTTON." "Expand display of the elided form at BUTTON."
(interactive)
(goto-char (button-start button)) (goto-char (button-start button))
(unless (get-text-property (point) 'cl-print-ellipsis) (unless (get-text-property (point) 'cl-print-ellipsis)
(if (and (> (point) (point-min)) (if (and (> (point) (point-min))

View file

@ -1807,7 +1807,6 @@ If no fileset name is provided, prompt for NAME."
(defun filesets-convert-patterns (name) (defun filesets-convert-patterns (name)
"Change fileset NAME's mode from :pattern to :files." "Change fileset NAME's mode from :pattern to :files."
(interactive)
(let ((entry (assoc name filesets-data))) (let ((entry (assoc name filesets-data)))
(if entry (if entry
(let ((pattern (filesets-entry-get-pattern entry)) (let ((pattern (filesets-entry-get-pattern entry))

View file

@ -683,7 +683,6 @@ previous state."
"Save the current state and start a new search based on ARGS. "Save the current state and start a new search based on ARGS.
The parameter ARGS is a cons cell where car is the word to search The parameter ARGS is a cons cell where car is the word to search
and cdr is the dictionary where to search the word in." and cdr is the dictionary where to search the word in."
(interactive)
(dictionary-store-positions) (dictionary-store-positions)
(let ((word (car args)) (let ((word (car args))
(dictionary (cdr args))) (dictionary (cdr args)))
@ -1258,7 +1257,6 @@ allows editing it."
:version "28.1") :version "28.1")
(defun dictionary-definition (word &optional dictionary) (defun dictionary-definition (word &optional dictionary)
(interactive)
(unwind-protect (unwind-protect
(let ((dictionary (or dictionary dictionary-default-dictionary))) (let ((dictionary (or dictionary dictionary-default-dictionary)))
(dictionary-do-search word dictionary 'dictionary-read-definition t)) (dictionary-do-search word dictionary 'dictionary-read-definition t))
@ -1315,7 +1313,6 @@ tooltip mode. The hook function will check the value of the
variable `dictionary-tooltip-mode' to decide if some action must be variable `dictionary-tooltip-mode' to decide if some action must be
taken. When disabling the tooltip mode the value of this variable taken. When disabling the tooltip mode the value of this variable
will be set to nil." will be set to nil."
(interactive)
(tooltip-mode on) (tooltip-mode on)
(if on (if on
(add-hook 'tooltip-functions #'dictionary-display-tooltip) (add-hook 'tooltip-functions #'dictionary-display-tooltip)

View file

@ -98,7 +98,6 @@ USER is a string representing a user name to be authenticated and
DOMAIN is a NT domain. USER can include a NT domain part as in DOMAIN is a NT domain. USER can include a NT domain part as in
user@domain where the string after @ is used as the domain if DOMAIN user@domain where the string after @ is used as the domain if DOMAIN
is not given." is not given."
(interactive)
(let ((request-ident (concat "NTLMSSP" (make-string 1 0))) (let ((request-ident (concat "NTLMSSP" (make-string 1 0)))
(request-msgType (concat (make-string 1 1) (make-string 3 0))) (request-msgType (concat (make-string 1 1) (make-string 3 0)))
;0x01 0x00 0x00 0x00 ;0x01 0x00 0x00 0x00

View file

@ -328,7 +328,6 @@
(advice-add 'open-network-stream :around #'socks--open-network-stream)) (advice-add 'open-network-stream :around #'socks--open-network-stream))
(defun socks-open-connection (server-info) (defun socks-open-connection (server-info)
(interactive)
(save-excursion (save-excursion
(let ((proc (let ((proc
(let ((socks-override-functions nil)) (let ((socks-override-functions nil))

View file

@ -1396,7 +1396,7 @@ regexps in `dcl-electric-reindent-regexps'."
;;;------------------------------------------------------------------------- ;;;-------------------------------------------------------------------------
(defun dcl-indent-to (col &optional minimum) (defun dcl-indent-to (col &optional minimum)
"Like `indent-to', but only indents if indentation would change." "Like `indent-to', but only indents if indentation would change."
(interactive) (interactive "NIndent to column: ")
(let (cur-indent collapsed indent) (let (cur-indent collapsed indent)
(save-excursion (save-excursion
(skip-chars-forward " \t") (skip-chars-forward " \t")

View file

@ -1130,7 +1130,7 @@ If given a numeric N-TIMES argument, mark that many classes."
(defun ebrowse-redraw-marks (start end) (defun ebrowse-redraw-marks (start end)
"Display class marker signs in the tree between START and END." "Display class marker signs in the tree between START and END."
(interactive) (interactive "r")
(save-excursion (save-excursion
(with-silent-modifications (with-silent-modifications
(catch 'end (catch 'end
@ -1494,9 +1494,9 @@ and possibly kill the viewed buffer."
(defun ebrowse-view-file-other-frame (file) (defun ebrowse-view-file-other-frame (file)
"View a file FILE in another frame. "View FILE in another frame.
The new frame is deleted when you quit viewing the file in that frame." The new frame is deleted when you quit viewing the file in that frame."
(interactive) (interactive "fIn other frame view file: ")
(let ((old-frame-configuration (current-frame-configuration)) (let ((old-frame-configuration (current-frame-configuration))
(had-a-buf (get-file-buffer file)) (had-a-buf (get-file-buffer file))
(buf-to-view (find-file-noselect file))) (buf-to-view (find-file-noselect file)))

View file

@ -3150,7 +3150,7 @@ Obeying it means displaying in another window the specified file and line."
(defun gud-basic-call (command) (defun gud-basic-call (command)
"Invoke the debugger COMMAND displaying source in other window." "Invoke the debugger COMMAND displaying source in other window."
(interactive) (interactive "sInvoke debugger command: ")
(gud-set-buffer) (gud-set-buffer)
(let ((proc (get-buffer-process gud-comint-buffer))) (let ((proc (get-buffer-process gud-comint-buffer)))
(or proc (error "Current buffer has no process")) (or proc (error "Current buffer has no process"))

View file

@ -3550,9 +3550,7 @@ This variable is ignored if `speedbar-use-imenu-flag' is t."
"Toggle FLAG in `speedbar-fetch-etags-arguments'. "Toggle FLAG in `speedbar-fetch-etags-arguments'.
FLAG then becomes a member of etags command line arguments. If flag FLAG then becomes a member of etags command line arguments. If flag
is \"sort\", then toggle the value of `speedbar-sort-tags'. If its is \"sort\", then toggle the value of `speedbar-sort-tags'. If its
value is \"show\" then toggle the value of value is \"show\" then toggle the value of `speedbar-show-unknown-files'."
`speedbar-show-unknown-files'."
(interactive)
(cond (cond
((equal flag "sort") ((equal flag "sort")
(setq speedbar-sort-tags (not speedbar-sort-tags))) (setq speedbar-sort-tags (not speedbar-sort-tags)))

View file

@ -2753,7 +2753,6 @@ in the region."
(defun treesit--explorer-jump (button) (defun treesit--explorer-jump (button)
"Mark the original text corresponding to BUTTON." "Mark the original text corresponding to BUTTON."
(interactive)
(when (and (derived-mode-p 'treesit--explorer-tree-mode) (when (and (derived-mode-p 'treesit--explorer-tree-mode)
(buffer-live-p treesit--explorer-source-buffer)) (buffer-live-p treesit--explorer-source-buffer))
(with-current-buffer treesit--explorer-source-buffer (with-current-buffer treesit--explorer-source-buffer

View file

@ -1846,7 +1846,6 @@ Argument EVENT is the invoking mouse event."
(defun woman-reset-emulation (value) (defun woman-reset-emulation (value)
"Reset `woman-emulation' to VALUE and reformat, for menu use." "Reset `woman-emulation' to VALUE and reformat, for menu use."
(interactive)
(setq woman-emulation value) (setq woman-emulation value)
(woman-reformat-last-file)) (woman-reformat-last-file))