diff --git a/lisp/use-package/use-package.el b/lisp/use-package/use-package.el index f933ce2d936..b20d149cb86 100644 --- a/lisp/use-package/use-package.el +++ b/lisp/use-package/use-package.el @@ -750,47 +750,44 @@ manually updated package." ;;; :bind, :bind* ;; -(defsubst use-package-is-sympair (x &optional allow-vector) - "Return t if X has the type (STRING . SYMBOL)." +(defsubst use-package-is-pair (x car-pred cdr-pred) + "Return non-nil if X is a cons satisfying the given predicates. +CAR-PRED and CDR-PRED are applied to X's `car' and `cdr', +respectively." (and (consp x) - (or (stringp (car x)) - (and allow-vector (vectorp (car x)))) - (symbolp (cdr x)))) - -(defsubst use-package-is-string-pair (x) - "Return t if X has the type (STRING . STRING)." - (and (consp x) - (stringp (car x)) - (stringp (cdr x)))) + (funcall car-pred (car x)) + (funcall cdr-pred (cdr x)))) (defun use-package-normalize-pairs - (name label arg &optional recursed allow-vector allow-string-cdrs) - "Normalize a list of string/symbol pairs. -If RECURSED is non-nil, recurse into sublists. -If ALLOW-VECTOR is non-nil, then the key to bind may specify a -vector of keys, as accepted by `define-key'. -If ALLOW-STRING-CDRS is non-nil, then the command name to bind to -may also be a string, as accepted by `define-key'." + (key-pred val-pred name label arg &optional recursed) + "Normalize a list of pairs. +KEY-PRED and VAL-PRED are predicates recognizing valid keys and +values, respectively. +If RECURSED is non-nil, recurse into sublists." (cond - ((or (stringp arg) (and allow-vector (vectorp arg))) + ((funcall key-pred arg) (list (cons arg (use-package-as-symbol name)))) - ((use-package-is-sympair arg allow-vector) + ((use-package-is-pair arg key-pred val-pred) (list arg)) ((and (not recursed) (listp arg) (listp (cdr arg))) (mapcar #'(lambda (x) (let ((ret (use-package-normalize-pairs - name label x t allow-vector allow-string-cdrs))) + key-pred val-pred name label x t))) (if (listp ret) (car ret) ret))) arg)) - ((and allow-string-cdrs (use-package-is-string-pair arg)) - (list arg)) (t arg))) (defun use-package-normalize-binder (name keyword args) (use-package-as-one (symbol-name keyword) args (lambda (label arg) - (use-package-normalize-pairs name label arg nil t t)))) + (unless (consp arg) + (use-package-error + (concat label " a ( . )" + " or list of these"))) + (use-package-normalize-pairs (lambda (k) (or (stringp k) (vectorp k))) + (lambda (b) (or (symbolp b) (stringp b))) + name label arg)))) (defalias 'use-package-normalize/:bind 'use-package-normalize-binder) (defalias 'use-package-normalize/:bind* 'use-package-normalize-binder) @@ -878,7 +875,9 @@ deferred until the prefix key sequence is pressed." (defun use-package-normalize-mode (name keyword args) (use-package-as-one (symbol-name keyword) args - (apply-partially #'use-package-normalize-pairs name))) + (apply-partially #'use-package-normalize-pairs + #'stringp (lambda (m) (and (not (null m)) (symbolp m))) + name))) (defalias 'use-package-normalize/:interpreter 'use-package-normalize-mode) diff --git a/test/lisp/use-package/use-package-tests.el b/test/lisp/use-package/use-package-tests.el new file mode 100644 index 00000000000..00682e9e0fc --- /dev/null +++ b/test/lisp/use-package/use-package-tests.el @@ -0,0 +1,59 @@ +;;; use-package-tests.el --- Tests for use-package.el + +;; This program is free software; you can redistribute it and/or +;; modify it under the terms of the GNU General Public License as +;; published by the Free Software Foundation; either version 2, or (at +;; your option) any later version. + +;; This program is distributed in the hope that it will be useful, but +;; WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +;; General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs; see the file COPYING. If not, write to the +;; Free Software Foundation, Inc., 59 Temple Place - Suite 330, +;; Boston, MA 02111-1307, USA. + +;;; Commentary: + +;; + + +;;; Code: + +(require 'ert) +(require 'use-package) + +(ert-deftest use-package-normalize-binder () + (let ((good-values '(:map map-sym + ("str" . sym) ("str" . "str") + ([vec] . sym) ([vec] . "str")))) + (should (equal (use-package-normalize-binder + 'foopkg :bind good-values) + good-values))) + (should-error (use-package-normalize-binder + 'foopkg :bind '("foo"))) + (should-error (use-package-normalize-binder + 'foopkg :bind '("foo" . 99))) + (should-error (use-package-normalize-binder + 'foopkg :bind '(99 . sym)))) + +(ert-deftest use-package-normalize-mode () + (should (equal (use-package-normalize-mode 'foopkg :mode '(".foo")) + '((".foo" . foopkg)))) + (should (equal (use-package-normalize-mode 'foopkg :mode '(".foo" ".bar")) + '((".foo" . foopkg) (".bar" . foopkg)))) + (should (equal (use-package-normalize-mode 'foopkg :mode '((".foo" ".bar"))) + '((".foo" . foopkg) (".bar" . foopkg)))) + (should (equal (use-package-normalize-mode 'foopkg :mode '((".foo"))) + '((".foo" . foopkg)))) + (should (equal (use-package-normalize-mode 'foopkg :mode '((".foo" . foo) (".bar" . bar))) + '((".foo" . foo) (".bar" . bar))))) + +;; Local Variables: +;; indent-tabs-mode: nil +;; no-byte-compile: t +;; no-update-autoloads: t +;; End: +;;; use-package-tests.el ends here