pestctrl/emacs
1
0
Fork 0
forked from Github/emacs
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't use mapconcat for effect

Browse source 
* lisp/progmodes/make-mode.el (makefile-browser-fill):
* lisp/url/url-mailto.el (url-mailto):
Use `mapc` instead of `mapconcat`.
This commit is contained in:
Mattias Engdegård 2023-04-10 15:20:27 +02:00
parent 119a7dd220
commit cb4f4dd891
2 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lisp/progmodes/make-mode.el
View file

@ -1326,14 +1326,12 @@ Fill comments, backslashed lines, and variable definitions specially."
(let ((inhibit-read-only t)) (let ((inhibit-read-only t))
(goto-char (point-min)) (goto-char (point-min))
(erase-buffer) (erase-buffer)
(mapconcat (mapc
(lambda (item) (insert (makefile-browser-format-target-line (car item) nil) "\n")) (lambda (item) (insert (makefile-browser-format-target-line (car item) nil) "\n"))
targets targets)
"") (mapc
(mapconcat
(lambda (item) (insert (makefile-browser-format-macro-line (car item) nil) "\n")) (lambda (item) (insert (makefile-browser-format-macro-line (car item) nil) "\n"))
macros macros)
"")
(sort-lines nil (point-min) (point-max)) (sort-lines nil (point-min) (point-max))
(goto-char (1- (point-max))) (goto-char (1- (point-max)))
(delete-char 1) ; remove unnecessary newline at eob (delete-char 1) ; remove unnecessary newline at eob

4
lisp/url/url-mailto.el
View file

@ -120,11 +120,11 @@
(url-mail-goto-field nil) (url-mail-goto-field nil)
(url-mail-goto-field "subject"))) (url-mail-goto-field "subject")))
(if url-request-extra-headers (if url-request-extra-headers
(mapconcat (mapc
(lambda (x) (lambda (x)
(url-mail-goto-field (car x)) (url-mail-goto-field (car x))
(insert (cdr x))) (insert (cdr x)))
url-request-extra-headers "")) url-request-extra-headers))
(goto-char (point-max)) (goto-char (point-max))
(insert url-request-data) (insert url-request-data)
;; It seems Microsoft-ish to send without warning. ;; It seems Microsoft-ish to send without warning.