From d66aa22c12031be7fe873ff6c55b0ffaf2cbaeb4 Mon Sep 17 00:00:00 2001 From: "brian m. carlson" Date: Fri, 18 Jul 2014 23:10:22 +0000 Subject: [PATCH] testgit: use with statements to open files. Signed-off-by: brian m. carlson --- test/testgit.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/testgit.py b/test/testgit.py index a0f275c..334a6b1 100755 --- a/test/testgit.py +++ b/test/testgit.py @@ -13,9 +13,8 @@ import unittest class TestGitTransactions(unittest.TestCase): def setUp(self): self.tempdir = tempfile.TemporaryDirectory() - fp = open(self.tempdir.name + "/schema", "w") - fp.write("fmt:0:newfol schema file:\ntxn:git\n") - fp.close() + with open(self.tempdir.name + "/schema", "w") as fp: + fp.write("fmt:0:newfol schema file:\ntxn:git\n") self.db = newfol.database.Database.load(self.tempdir.name) def tearDown(self): @@ -58,9 +57,8 @@ class TestGitTransactions(unittest.TestCase): data = None try: os.chdir(self.tempdir.name) - fp = os.popen("git log --pretty=format:" + fmt + " -n1") - data = fp.read() - fp.close() + with os.popen("git log --pretty=format:" + fmt + " -n1") as fp: + data = fp.read() finally: os.chdir(cwd) return data