Commit graph

138433 commits

Author SHA1 Message Date
Paul Eggert
2c2f0eb9fc Remove obsolete Lint directives
Most of the directives were wrong anyway.  Apparently
traditional lint hasn’t been used to check Emacs for years.
* src/callint.c (Finteractive):
* src/cm.c (evalcost):
* src/emacs.c (main):
* src/eval.c (call1, call2, call3, call4, call5, call6, call7, call8):
* src/fns.c (concat2, concat3, nconc2):
* src/term.c (calculate_ins_del_char_costs):
Omit ARGSUSED comments.
* src/eval.c (call1): Omit VARARGS comment.
2019-09-16 14:05:03 -07:00
Tino Calancha
57ac6523af Add backquote tests
* test/lisp/emacs-lisp/backquote-tests.el: New file (bug#37432).
2019-09-16 22:57:35 +02:00
Paul Eggert
2335704fcc directory-files cleanup and speed tweaking
* src/dired.c (directory_files_internal):
Check ‘match’ before doing anything heavyweight.
Move decls closer to use.
Remove obsolete comments about GC.
No need to encode ‘directory’ or to call multibyte_chars_in_text.
Remove no-longer-needed bug check.
Skip finalname construction if file_attributes fails.
2019-09-16 13:55:23 -07:00
Lars Ingebrigtsen
1a84d8fba4 mm-inline-large-images-proportion doc clarification
* lisp/gnus/mm-view.el (mm-inline-large-images-proportion): Doc
clarification.
2019-09-16 22:31:29 +02:00
Lars Ingebrigtsen
e468315075 Default to rescaling images in mm buffers
* doc/misc/emacs-mime.texi (Display Customization): Document it.

* lisp/gnus/mm-decode.el (mm-inline-large-images): Change default
to `resize'.
2019-09-16 22:30:04 +02:00
Lars Ingebrigtsen
f1e5877a6b mm-inline-large-images doc string clarification
* lisp/gnus/mm-decode.el (mm-inline-large-images): Clarify doc string.
2019-09-16 22:22:54 +02:00
Mauro Aranda
f22346fe5a With tooltip-mode disabled, don't unconditionally clear the echo area
* lisp/tooltip.el (tooltip-show-help-non-mode): Only clear the
echo area when the current message displayed is a tooltip message
(Bug#3192).
2019-09-16 22:17:51 +02:00
Lars Ingebrigtsen
72ad41c059 Minor fix for previous maintaining.texi change
* doc/emacs/maintaining.texi (VC Directory Commands): Use @file
for files.
2019-09-16 22:08:57 +02:00
Lars Ingebrigtsen
dbf2f18f17 Document vc-dir-ignore
* doc/emacs/maintaining.texi (VC Directory Commands): Document
vc-dir-ignore.
2019-09-16 22:03:02 +02:00
Eli Zaretskii
facd6d5aff Improve error reporting in file_accessible_directory_p
* src/w32.c (w32_accessible_directory_p): Set errno, so that
file_accessible_directory_p does on MS-Windows, to live up to
its callers' expectations.
2019-09-16 22:19:16 +03:00
Eli Zaretskii
169d04b8ac Fix initialization of shared-game-score-directory on MS-Windows
* src/callproc.c (init_callproc) [WINDOWSNT]: Run PATH_GAME
through w32_relocate, to expand %emacs_dir%.
[DOS_NT]: Accept EACCES as not "unusual" errno value.
Reported by Richard Copley <rcopley@gmail.com>.
2019-09-16 17:51:25 +03:00
Michael Albinus
6684db8cea ; Disable traces in shadowfile-tests 2019-09-16 15:00:37 +02:00
Lars Ingebrigtsen
dfc17fc02e Remove NEWS entry that talks about a change that was reverted (bug#37257) 2019-09-16 14:32:17 +02:00
Robert Pluim
3a18c82b8e Add bindings for ligature oe to iso-transl-char-map
* lisp/international/iso-transl.el (iso-transl-char-map): Add bindings
for small and capital ligature oe.  (Bug#23420)
2019-09-16 10:09:48 +02:00
Paul Eggert
be82888347 Fix some file-name-case-insensitive glitches
* src/fileio.c (file_name_directory): New static function,
broken out of Ffile_name_directory.
(file_name_case_insensitive_err, Ffile_writable_p, Fdo_auto_save):
Use it.
(file_name_case_insensitive_err): Rename from
file_name_case_insensitive_p.  Accept an unencoded Lisp_Object
rather than an encoded char *, so that platforms other than
Cygwin and macOS need not encode the file name.  Return an int
-1, 0, errno rather than a bool (setting errno if false),
so that the caller can distinguish an error from false.
All callers changed.
(Ffile_name_case_insensitive_p): Don’t issue system calls on
platforms other than Cygwin and macOS.  Fix bug that broke the
attempt to move up the filesystem tree (it moved up only one
level).
2019-09-15 22:15:28 -07:00
Stefan Kangas
5711c076dc ; * etc/NEWS: Fix typo. 2019-09-16 06:55:02 +02:00
Paul Eggert
ba0605779e Fix unknown-vs-nonexistent glitch for file timestamps
* src/fileio.c (time_error_value): EACCES means the file
timestamp is unknown, not that the file does not exist.
2019-09-15 20:18:06 -07:00
Paul Eggert
de3daf0639 Improve directory-access diagnostics
* src/callproc.c (init_callproc): Diagnose I/O errors,
access errors, etc. for the game directory.
* src/charset.c (init_charset): Improve quality of diagnostic
when the charsets directory has I/O errors, access errors, etc.
2019-09-15 20:12:33 -07:00
Glenn Morris
a625ca5c26 Merge from origin/emacs-26
30c4f35 (origin/emacs-26) query-replace-regexp undo: Update next-repl...
c596be0 Amend the menu caption for page "Display Property" in the Eli...
13b9510 Add description of chinese-sisheng
2019-09-15 16:38:23 -07:00
Glenn Morris
211dc01a7b ; Merge from origin/emacs-26
The following commit was skipped:

7e527af Fix non-deterministic process test
2019-09-15 16:38:23 -07:00
Glenn Morris
8297df9d4b Merge from origin/emacs-26
8e420c0 Clarify the use of left/right-margin-width in determining cur...
2019-09-15 16:38:20 -07:00
Glenn Morris
7582cde427 ; Merge from origin/emacs-26
The following commit was skipped:

0c3fc71 ; Bump Emacs version to 26.3.50
2019-09-15 16:38:20 -07:00
Glenn Morris
84c7d4bccc * admin/upload-manuals: Move a basic check earlier. 2019-09-15 16:36:06 -07:00
Juanma Barranquero
b3e4b50578 * lisp/subr.el (major-mode-suspend): Doc fix 2019-09-15 20:37:26 +02:00
Michael Albinus
6d3cb263f9 Use also truname of temporary-file-directory in shadowfile-tests.el
* test/lisp/shadowfile-tests.el (top): Use truename of
`temporary-file-directory' and
`shadow-test-remote-temporary-file-directory'.  (Bug#37202)
(shadow-test08-shadow-todo, shadow-test09-shadow-copy-files):
Do not bind `shadow-test-remote-temporary-file-directory'.
2019-09-15 16:52:22 +02:00
Mauro Aranda
24e0546bc1 Make widget-browse-at always detect an editable-field
* lisp/wid-browse.el (widget-browse-at): Also look for the real-field
property when detecting a field (bug#37199).
2019-09-15 15:21:08 +02:00
Wolfgang Scherer
12b1cce925 Do not use error messages as list of ignored files in vc-svn
* lisp/vc/vc-svn.el: (vc-svn-ignore-completion-table) Ignore buffer
contents, if exit status is not 0.  Split buffer by lines (bug#37214).
2019-09-15 15:14:44 +02:00
Wolfgang Scherer
f144c87f92 Fix vc-default-ignore
* lisp/vc/vc.el: (vc-default-ignore) Treat FILE parameter as relative
to DIRECTORY parameter.  Construct a file-path relative to directory
of ignore file.  When removing, use properly anchored regexp.  Remove
entire line, not just the match (bug#37217).
2019-09-15 15:03:33 +02:00
Wolfgang Scherer
c99c9ec28c Provide facility to ignore all marked files in vc
* lisp/vc/vc-dir.el: (vc-dir-ignore) With prefix argument, ignore all
marked files (bug#37240).
2019-09-15 15:00:20 +02:00
Lars Ingebrigtsen
f198a5c514 Revert "emacsclient: ignore --eval parameters when starting alternate editor"
This reverts commit 6fe661342a.

The alternate editor may be Emacs, which is useful when you want to eval something in an existing Emacs (if it exists), or in a new Emacs if there's no server running.
2019-09-15 14:11:14 +02:00
Paul Eggert
dbc57b5573 file_name_case_insensitive_p int->long fix
* src/fileio.c (file_name_case_insensitive_p):
Don’t assume ‘long int’ fits in ‘int’.
2019-09-14 22:00:42 -07:00
Paul Eggert
52172d2340 Fix gc-elapsed rounding bug
* src/alloc.c (garbage_collect): Don’t accumulate rounding
errors when computing gc-elapsed.
2019-09-14 10:56:12 -07:00
Paul Eggert
1acc0cc9aa Improve doc of GC thresholds
* doc/lispref/internals.texi (Garbage Collection), etc/NEWS:
Warn that control over GC is only approximate.
2019-09-14 10:56:12 -07:00
Bruno Félix Rezende Ribeiro
3f43adac49 Fix picon installation instructions in the Gnus manual
* doc/misc/gnus.texi (Picons): Fix instructions for installing
picons on Debian (bug#37247).

Copyright-paperwork-exempt: yes
2019-09-14 17:00:40 +02:00
Basil L. Contovounesios
c6d8143453 Fix fileless eww form submission
* lisp/net/eww.el (eww-submit): Ignore file inputs with no
associated file name (bug#36520).
2019-09-14 16:55:24 +02:00
Lars Ingebrigtsen
5a0ab88cc9 Add default foreground colours to SVG images
* lisp/net/shr.el (svg--wrap-svg): Add a default foreground colour
to SVG images (bug#37159).  This helps with images like the ones
in https://en.wikipedia.org/wiki/Banach_fixed-point_theorem that
specify no foreground or background colours.
(shr-parse-image-data): Use it.
2019-09-14 16:48:21 +02:00
Lars Ingebrigtsen
568f1488a6 Make eww more liberal when interpreting some invalid HTML
* lisp/net/eww.el (eww--preprocess-html): New function (bug#37009)
to be more lenient with invalid HTML and translate common invalid
HTML like "a <= b" into "a &lt;= b" to be more liberal in what we
accept before parsing.
(eww-display-html): Use it.
(eww-readable): Ditto.
2019-09-14 16:10:23 +02:00
Eli Zaretskii
49a4b86925 * src/print.c (PRINT_CIRCLE_CANDIDATE_P): Fix a thinko. (Bug#36566) 2019-09-14 17:04:30 +03:00
Tobias Zawada
5f7531f9e9 Add a debug declaration to widget-specify-insert
* lisp/wid-edit.el (widget-specify-insert): Add a debug
declaration (bug#37368).

Copyright-paperwork-exempt: yes
2019-09-14 14:20:03 +02:00
Eli Zaretskii
53a1a29bec ; * etc/NEWS: Fix last change. 2019-09-14 11:21:40 +03:00
Federico Tedin
36bf5534bf Allow gamegrid-add-score to treat lower scores as better.
* lisp/play/gamegrid.el (gamegrid-add-score): Add 'reverse' parameter.
(gamegrid-add-score-with-update-game-score): Add 'reverse' parameter.
(gamegrid-add-score-with-update-game-score-1): Add 'reverse'
parameter.  Pass on "-r" argument to update-game-score.
(gamegrid-add-score-insecure): Add 'reverse' parameter, reverse scores
when it's non-nil.  (Bug#36867)

* etc/NEWS: Announce the change.
2019-09-14 11:20:32 +03:00
Paul Eggert
bac66302e9 Improve gc-cons-percentage calculation
The old calculation relied on a hodgpodge of partly updated GC
stats to find a number to multiply gc-cons-percentage by.
The new one counts data found by the previous GC, plus half of
the data allocated since then; this is more systematic albeit
still ad hoc.
* src/alloc.c (consing_until_gc, gc_threshold, consing_threshold):
Now EMACS_INT, not intmax_t.
(HI_THRESHOLD): New macro.
(tally_consing): New function.
(make_interval, allocate_string, allocate_string_data)
(make_float, free_cons, allocate_vectorlike, Fmake_symbol): Use it.
(allow_garbage_collection, inhibit_garbage_collection)
(consing_threshold, garbage_collect):
Use HI_THRESHOLD rather than INTMAX_MAX.
(consing_threshold): New arg SINCE_GC.  All callers changed.
(bump_consing_until_gc): Return new consing_until_gc, instead of
nil.  All callers changed.  Don’t worry about overflow since we
now saturate at HI_THRESHOLD.  Guess that half of
recently-allocated objects are still alive, instead of relying on
the previous (even less-accurate) hodgepodge.
(maybe_garbage_collect): New function.
(garbage_collect): Work even if a finalizer disables or enables
memory profiling.  Do not use malloc_probe if GC reclaimed nothing.
* src/lisp.h (maybe_gc): Call maybe_garbage_collect instead
of garbage_collect.
2019-09-14 00:37:26 -07:00
Paul Eggert
e4fb98b542 Simplify GC statistics-gathering
* src/alloc.c (make_interval, allocate_string, make_float)
(free_cons, Fcons, setup_on_free_list)
(allocate_vector_from_block, Fmake_symbol):
Do not update gcstat, since it is for statistics from the most
recent GC, not for a partially-updated hodgepodge.
(sweep_vectors): Update gcstat, since setup_on_free_list
no longer does.
(garbage_collect_1): Rename to garbage_collect and adopt its API.
Remove the old garbage_collect, which is no longer needed.
All callers changed.
2019-09-13 16:10:54 -07:00
Gemini Lasswell
0dba340da5 Don't build print-number-table unless it will be used
There are only a few users of print-number-table, and none of them use
it when print-circle is nil.  A couple of them used to.  print_object
was changed in 2012-04-20 "* src/print.c (print_preprocess): Only
check print_depth if print-circle is nil".
byte-compile-output-docform which uses print-number-table binds
print-circle to t before printing unless
byte-compile-disable-print-circle is set, but that variable has been
marked obsolete since 24.1.

* src/print.c (print_preprocess): Assert Vprint_circle is non-nil.
Remove code handling the case when Vprint_circle is nil.
(print, Fprint_preprocess): Don't call print_preprocess unless
Vprint_circle is non-nil.
(print_object): Remove comment referencing removed code in
print_preprocess.
2019-09-13 13:43:07 -07:00
Gemini Lasswell
3bd6ef40b5 Create common tests for print.c and cl-print.el
* test/lisp/emacs-lisp/cl-print-tests.el
(cl-print--test, cl-print-tests-1, cl-print-tests-2)
(cl-print-tests-3, cl-print-tests-4, cl-print-tests-5)
(cl-print-tests-strings, cl-print-circle, cl-print-circle-2):
Remove.
* test/src/print-tests.el (print-tests--prin1-to-string): New
alias.
(print-tests--deftest): New macro.
(print-hex-backslash, print-read-roundtrip, print-bignum): Define with
print-tests--deftest and use print-tests--prin1-to-string.
(print-tests--prints-with-charset-p): Use
print-tests--prin1-to-string.
(print-tests--print-charset-text-property-nil)
(print-tests--print-charset-text-property-t)
(print-tests--print-charset-text-property-default): Define with
print-tests--deftest.
(print-tests-print-gensym)
(print-tests-continuous-numbering, print-tests-1, print-tests-2)
(print-tests-3, print-tests-4, print-tests-5)
(print-tests-strings, print-circle, print-circle-2): New tests.
(print--test, print-tests-struct): New cl-defstructs.
2019-09-13 13:43:07 -07:00
Gemini Lasswell
6eaf39d21b Fix unnecessary hash table creation in cl-prin1 (bug#36566)
cl-prin1 prints all its punctuation by passing strings to prin1.  When
print-circle was set, print_preprocess was creating a new hash table
for each string, causing excessive garbage collection when printing
large Lisp objects with cl-prin1.

* src/print.c (print_number_index): Fix typo in comment above.
(PRINT_CIRCLE_CANDIDATE_P): Don't create print_number_table
for top-level strings with no properties, except when
print_continuous_numbering is on.
2019-09-13 13:43:07 -07:00
Gemini Lasswell
5c40c21a47 Improve performance of backtrace printing (bug#36566)
* lisp/emacs-lisp/cl-print.el (cl-print-to-string-with-limit): Reduce
print-level and print-length more quickly when the structure being
printed is very large.
2019-09-13 13:43:07 -07:00
Gemini Lasswell
2093395dbf Improve print output options commands in backtrace-mode (bug#36566)
* lisp/emacs-lisp/backtrace.el (backtrace-view): Mention
:print-gensym in docstring.
(backtrace-mode-map): Add keyboard binding for
backtrace-toggle-print-gensym.  Add menu entries for
backtrace-toggle-print-circle and backtrace-toggle-print-gensym.
(backtrace--with-output-variables): Bind print-gensym with value
of :print-gensym found in view plist.
(backtrace-toggle-print-circle): Remove description of
implementation details from docstring.
(backtrace-toggle-print-gensym): New command.
(backtrace--toggle-feature): Add echo area message describing result
of command.

* test/lisp/emacs-lisp/backtrace-tests.el
(backtrace-tests--print-circle): New test.

* doc/lispref/debugging.texi (Backtraces): Document keyboard
binding for backtrace-toggle-print-gensym.
2019-09-13 13:43:07 -07:00
Stefan Kangas
224534ab8d * lisp/help-mode.el (help-mode-menu): Fix typo. (Bug#36485) 2019-09-13 20:51:06 +02:00
Stefan Kangas
9ad3f5d1d2 * doc/misc/efaq.texi: Update ancient formats. (Bug#37143) 2019-09-13 20:28:15 +02:00